BREAKING: Android - ReactNativeHost getUseDeveloperSupport to public

[jpshelley]

Overview

Currently React Native is opinionated in that the easiest approach is to extend ReactActivity. However to more easily allow integrating with existing application, we should allow some of the methods in ReactNativeHost to be public, and this is a very good first step.

• There is no harm in making this public from what I can tell.
• This allows ReactNativeHost to be more easily used outside of the ReactActivity and ReactActivityDelegate ecosystem. (A ReactFragment would be a good example)

Addresses / Changes

No issues found

Test plan (required)

• Run any sample app and verify it still works.

Make sure tests pass on both Travis and Circle CI.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @foghina and @AaaChiuuu to be potential reviewers.

[facebook-github-bot]

@AaaChiuuu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[jpshelley]

Looks like Circle failed, I can't tell how to fix the failure though.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[mkonicek]

As expected, we have some closed-source code that extends the application that we'll need to update.

Error from internal CI:

getUseDeveloperSupport() in com.facebook.someapp.SomeClass cannot override getUseDeveloperSupport()

[mkonicek]

@jpshelley Is this change going to break the build for anyone overriding this method as protected boolean getUseDeveloperSupport() in their apps?

If yes, we need to clearly mark it as a breaking change (just did that).

How common is to override this method? Will this break the build for a lot of people?

[jpshelley]

@mkonicek

How common is to override this method?

According to the react native documentation, it will be very common for others to override this.

• react-native/Examples/Movies/android/app/src/main/java/com/facebook/react/movies/MoviesApplication.java

  Line 42 in 9ee815f

  protected boolean getUseDeveloperSupport() {

• react-native/Examples/TicTacToe/android/app/src/main/java/com/facebook/react/tictactoe/TicTacToeApplication.java

  Line 42 in 9ee815f

  protected boolean getUseDeveloperSupport() {

• react-native/Examples/UIExplorer/android/app/src/main/java/com/facebook/react/uiapp/UIExplorerApplication.java

  Line 42 in 9ee815f

  public boolean getUseDeveloperSupport() {

Whats strange is UIExplorer (3rd link) already has it as public.

Will this break the build for a lot of people?

Yes this will unfortunately. It is a quick fix from changing the scope from protected to public.

[jpshelley]

@mkonicek Is this something we can move forward on still? Like I said, some applications use a single activity multiple fragment approach and this would allow for creating a React Fragment.

[aaronechiu]

I'm attempting to fix the breakage internally right now; we'll see how it goes.

[jpshelley]

@AaaChiuuu it looks like the PR was accepted, however it didn't pick up all the changes. Was this intentional? I fear the example applications and any new ones started via the CLI won't build correctly.

[aaronechiu]

Crap, wanna send a new PR?

[jpshelley]

@AaaChiuuu I can, can you not take the commits from this PR somehow?

[aaronechiu]

can't re-import the same PR