Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Blob support for XMLHttpRequest #11573

Closed
wants to merge 76 commits into from
Closed

Implement Blob support for XMLHttpRequest #11573

wants to merge 76 commits into from

Commits on Jun 12, 2017

  1. Add blob implementation with WebSocket integration 

    Fix import paths after rebasing

Modify build targets
    @philikon @satya164
    philikon authored and satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    642d451 View commit details
    Browse the repository at this point in the history

  2. Add a 'fromURI' method to blob

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    be07fa9 View commit details
    Browse the repository at this point in the history

  3. Fix blob not sliced when offset is 0

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    e8ea388 View commit details
    Browse the repository at this point in the history

  4. Add blob support to XMLHttpRequest

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    553f20e View commit details
    Browse the repository at this point in the history

  5. Make blob properties read-only following the spec

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    aaba705 View commit details
    Browse the repository at this point in the history

  6. Add a basic implementation for FileReader on Android

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    22ebafb View commit details
    Browse the repository at this point in the history

  7. Fix getting mime type

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    781e9e6 View commit details
    Browse the repository at this point in the history

  8. Add unit tests for Blob and File

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    109a465 View commit details
    Browse the repository at this point in the history

  9. Implement creating blob from string

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    2746628 View commit details
    Browse the repository at this point in the history

  10. Add tests for blob module

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    a60605d View commit details
    Browse the repository at this point in the history

  11. Cast blob parts to string

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    d4b62b9 View commit details
    Browse the repository at this point in the history

  12. Fix counting bytes

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    600217a View commit details
    Browse the repository at this point in the history

  13. Fix test for createFromParts

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    b1614c1 View commit details
    Browse the repository at this point in the history

  14. Don't allow accessing data after blob is closed

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    8ad6369 View commit details
    Browse the repository at this point in the history

  15. Keep track of blobs and release when blobs are released

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    968a7b8 View commit details
    Browse the repository at this point in the history

  16. Fix typo in BlobManager

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    60f8ebb View commit details
    Browse the repository at this point in the history

  17. Use fetch to retrive blob from URI

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    f56c66b View commit details
    Browse the repository at this point in the history

  18. Add support for downloading blobs on iOS

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    7c0d8b2 View commit details
    Browse the repository at this point in the history

  19. Fix typo in base64 conversion

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    d62da30 View commit details
    Browse the repository at this point in the history

  20. Fix uploading blob via XHR

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    39feed9 View commit details
    Browse the repository at this point in the history

  21. Basic implementation of file reader

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    1a6060a View commit details
    Browse the repository at this point in the history

  22. Revert unwanted changes

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    8880eb9 View commit details
    Browse the repository at this point in the history

  23. Fix RNTester app

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    9930649 View commit details
    Browse the repository at this point in the history

  24. Fix BUCK

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    8b6fd3f View commit details
    Browse the repository at this point in the history

  25. Respect specified encoding for readAsText

    @satya164
    satya164 committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    d0efa54 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. Initial merge

    @grabbou
    grabbou committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    c2fa7ff View commit details
    Browse the repository at this point in the history

  2. Attempt to merge #23102931

    @grabbou
    grabbou committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    5c2dd2c View commit details
    Browse the repository at this point in the history

  3. Some fixes

    @satya164
    satya164 committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    5fc2acb View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. Make blob work on Android

    @satya164
    satya164 committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    e644c21 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2017

  1. Fix the file constructor and remove leftover file

    @satya164
    satya164 committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    9798801 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2017

  1. Make blob module optional on Android

    @satya164
    satya164 committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    8564ec8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/blob

    @satya164
    satya164 committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    71b69ed View commit details
    Browse the repository at this point in the history

  3. Fix compilation error on iOS

    @satya164
    satya164 committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    1479086 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2017

  1. Remove dependency

    @RoninSTi @janicduplessis
    RoninSTi authored and janicduplessis committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    d9d3295 View commit details
    Browse the repository at this point in the history

  2. Fixes, cleanup and @Format

    @janicduplessis
    janicduplessis committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    ccf580e View commit details
    Browse the repository at this point in the history

  3. Xcodeproj fixes, add ios tests

    @janicduplessis
    janicduplessis committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    6159d5b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Merge remote-tracking branch 'upstream/master' into feat/blob

    @janicduplessis
    janicduplessis committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    0dbe167 View commit details
    Browse the repository at this point in the history

  2. Improve architecture and fix potential thread safety issues on iOS

    @janicduplessis
    janicduplessis committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    cc9a425 View commit details
    Browse the repository at this point in the history

  3. Remove blob include

    @janicduplessis
    janicduplessis committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    ed2b250 View commit details
    Browse the repository at this point in the history

  4. Revert websocket xcodeproj changes

    @janicduplessis
    janicduplessis committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    f928990 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Avoid statics for module data to make multiple instances play nicely, 

    cleanup whitespace changes
    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    35a37b6 View commit details
    Browse the repository at this point in the history

  2. Fix whitespace p2

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    adc5318 View commit details
    Browse the repository at this point in the history

  3. Fix whitespace p3

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    e70fb7e View commit details
    Browse the repository at this point in the history

  4. Improve buffer resize condition to match ios

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    37a0269 View commit details
    Browse the repository at this point in the history

  5. More cleanup

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    1aa1f84 View commit details
    Browse the repository at this point in the history

  6. Fix buck files

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    8e98f95 View commit details
    Browse the repository at this point in the history

  7. Document networking interfaces

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    45d014a View commit details
    Browse the repository at this point in the history

  8. Static NAME

    @janicduplessis
    janicduplessis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    21ff09b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2017

  1. Fix flow

    @janicduplessis
    janicduplessis committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    cd6ede7 View commit details
    Browse the repository at this point in the history

  2. Fix buck build

    @janicduplessis
    janicduplessis committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    b536989 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2017

  1. Fix android tests, cleanup createFromURI leftovers

    @janicduplessis
    janicduplessis committed Oct 8, 2017
    Configuration menu
    Copy the full SHA
    75b4f1e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2017

  1. Merge branch 'master' into feat/blob

    @janicduplessis
    janicduplessis committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    d3a36ae View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Merge branch 'master' into feat/blob

    @janicduplessis
    janicduplessis committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    03165ca View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. Merge branch 'master' into feat/blob

    @satya164
    satya164 committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    3a28ad1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/blob

    @satya164
    satya164 committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    a977635 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2017

  1. Merge branch 'master' into feat/blob

    @janicduplessis
    janicduplessis committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    ebe159e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2017

  1. Merge branch 'master' into feat/blob

    @hramos
    hramos committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    1de53b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. Merge branch 'master' into feat/blob

    @janicduplessis
    janicduplessis committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    ec88828 View commit details
    Browse the repository at this point in the history

  2. Fix invariant import, cleanup networking module imports

    @janicduplessis
    janicduplessis committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    fb3496a View commit details
    Browse the repository at this point in the history

  3. Address some review feedback

    @janicduplessis
    janicduplessis committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    c243471 View commit details
    Browse the repository at this point in the history

  4. Fix prettier

    @janicduplessis
    janicduplessis committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    368b86e View commit details
    Browse the repository at this point in the history

  5. Fix android build

    @janicduplessis
    janicduplessis committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    20cdd7e View commit details
    Browse the repository at this point in the history

  6. Replace ♥ with \u{2665} 

    Source code should only include printable US-ASCII bytes. Use Unicode escapes like \u to represent non-US-ASCII values.
    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    84953bf View commit details
    Browse the repository at this point in the history

  7. Fix lint issue in BlobModuleTest.java 

    Don't use @RunWith(RobolectricTestRunner.class) Use @RunWith(WithTestDefaultsRunner.class) instead
    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    ddcbc64 View commit details
    Browse the repository at this point in the history

  8. Use correct unicode escapte

    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    4c7a928 View commit details
    Browse the repository at this point in the history

  9. Use string literal escapes for unicode

    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    da15540 View commit details
    Browse the repository at this point in the history

  10. Update FileReaderModule.java 

    Copyright header should be at the top
    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    28d1500 View commit details
    Browse the repository at this point in the history

  11. Update RCTBlobManagerTests.m 

    Source code should only include printable US-ASCII bytes. Use Unicode escapes like \u to represent non-US-ASCII values.
    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    00408ab View commit details
    Browse the repository at this point in the history

  12. Update RCTBlobManager.mm 

    - Imports out of order
    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    236ed3f View commit details
    Browse the repository at this point in the history

  13. Insert ⏎····· (prettier/prettier)

    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    35e0c1c View commit details
    Browse the repository at this point in the history

  14. Update Blob-test.js

    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    e2481c4 View commit details
    Browse the repository at this point in the history

  15. Update Blob-test.js

    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    5d215ce View commit details
    Browse the repository at this point in the history

  16. Add back missing handler code that was lost in merge

    @janicduplessis
    janicduplessis committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    5494fe9 View commit details
    Browse the repository at this point in the history

  17. Fix trailing whitespace on RCTBlobManager.mm 

    (TXT6) Trailing Whitespace at line 30
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT6) Trailing Whitespace at line 101
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT6) Trailing Whitespace at line 105
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT6) Trailing Whitespace at line 116
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT6) Trailing Whitespace at line 241
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT6) Trailing Whitespace at line 247
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT6) Trailing Whitespace at line 277
This line contains trailing whitespace. Consider setting up your editor to automatically remove trailing whitespace, you will save time.
Autofix	(TXT9) Trailing Whitespace at EOF at line 287
    @hramos
    hramos committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    ad568cf View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Import uuid from uuid/v4 to avoid conflict with internal fb haste module

    @janicduplessis
    janicduplessis committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    2f15886 View commit details
    Browse the repository at this point in the history

  2. Fix test runner

    @janicduplessis
    janicduplessis committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    d56239b View commit details
    Browse the repository at this point in the history