ImagePickerIOS take photo with wrong orientation #12249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImagePickerIOS take photo save orientation info
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
anyone can help review ? |
|
Hey! I've been going through PRs and would like to get this one moving. Two things stand out to me: there is no test plan, and there is no example of what happens prior to the fix. Ideally your PR would include all of the sections listed in the PR template. This will help us gauge the extent of the problem as well as understand how the fix was tested. |
|
@shergin Hi! Any chance to see this PR merged? I also have this bug with photo orientation and this patch works for me. |
|
@doochik see my comment above, this PR lacks a test plan. Since there has been no response from the author, I'll close it. Feel free to open a new PR if you feel strongly about getting this merged. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 25, 2017
Summary: Original PR: #12249 ImagePickerIOS saves photos to ImageStoreManager without meta information. So photo has wrong orientation. **Test plan** 1. Take the 2 photos (in landspape and portrait orientation) with this code: ``` ImagePickerIOS.openCameraDialog( {}, (uri) => CameraRoll.saveToCameraRoll(uri), () => {} ); ``` 2. Ensure that photos in Photos app have right orientation. Closes #15060 Differential Revision: D5487595 Pulled By: shergin fbshipit-source-id: ce1a47f4d5ba33e03070f318f3d6a8dd0df5ab88
AntiPaste
pushed a commit
to TaitoUnited/react-native
that referenced
this pull request
Aug 23, 2017
Summary: Original PR: facebook#12249 ImagePickerIOS saves photos to ImageStoreManager without meta information. So photo has wrong orientation. **Test plan** 1. Take the 2 photos (in landspape and portrait orientation) with this code: ``` ImagePickerIOS.openCameraDialog( {}, (uri) => CameraRoll.saveToCameraRoll(uri), () => {} ); ``` 2. Ensure that photos in Photos app have right orientation. Closes facebook#15060 Differential Revision: D5487595 Pulled By: shergin fbshipit-source-id: ce1a47f4d5ba33e03070f318f3d6a8dd0df5ab88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ImagePickerIOS camera take photo, photos only have landscape orientation, which is not matched with fact.
So I add a function to save orientation info.