CI: Fast finish Travis builds, disable tvOS and JS tests #12603
Conversation
facebook-github-bot
added
CLA Signed
mkonicek
force-pushed
the
fast_finish
branch
2 times, most recently
from
115f47b
to
90c146c
Compare
mkonicek
changed the title
|
@hramos liked this PR and @lacker liked the comment on an internal post about this PR, so I take it it's been accepted :) Tests passed except one unrelated failure:
See https://travis-ci.org/facebook/react-native/builds/205892984 Merging. |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@facebook-github-bot shitpit-ninja |
|
Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
Awesome. I wonder if it would similarly help to take the most-faily tests, and have them run first? |
|
@lacker That could help actually! |
mkonicek
force-pushed
the
fast_finish
branch
2 times, most recently
from
4db0cd5
to
c9ce627
Compare
|
@lacker The builds run in parallel but there is a part in the Travis docs suggesting the order can matter ("test suite ... is usually going to be done before ..."):
https://docs.travis-ci.com/user/speeding-up-the-build/ The tests are rendered in the Travis UI in the order defined in this PR (seems like it might work):
https://travis-ci.org/facebook/react-native/builds/206218787 |
mkonicek
force-pushed
the
fast_finish
branch
3 times, most recently
from
d006eaf
to
b366a09
Compare
mkonicek
changed the title
mkonicek
changed the title
Reviewed By: mkonicek Differential Revision: D4635182 Ninja: Manual import #12603 fbshipit-source-id: f512bf3ce7840b3fbc229e9225e06e3112d849d3
|
Imported to fb codebase manually in e44730c |
Reviewed By: mkonicek Differential Revision: D4635182 Ninja: Manual import facebook#12603 fbshipit-source-id: f512bf3ce7840b3fbc229e9225e06e3112d849d3
On Travis all fb projects share the same org and wait around a day for test results.
When a test fails we're still using Travis capacity to run other tests:
https://travis-ci.org/facebook/react-native/builds/206214009
Could failing fast help? Docs: https://docs.travis-ci.com/user/customizing-the-build/#Fast-Finishing
Also disable tvOS tests. The reason is it turns out React Native builds are a major contributor to slowing down Travis on Mac for everyone int the world, and the tvOS tests take a significant portion of the work. Messaged @dlowder-salesforce about this. Sorry we have to do this for now until Travis hopefully adds lots of Mac capacity.
Also disable JS tests. We now spend around 10% of time on Travis running these. The exact same tests run on Circle CI.
Test Plan
This PR is based on master which is currently failing, so Travis tests will fail.
Looks like builds were canceled after some builds failed: