Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Boost dependency to 1.63 on iOS #12838

Closed
wants to merge 1 commit into from

Conversation

mkonicek
Copy link
Contributor

@mkonicek mkonicek commented Mar 9, 2017

We use this version internally.

Test plan: Asked @mhorowitz:

  • open Examples/UIExplorer/UIExplorerCxx.xcodeproj
  • build and run the UIExplorer scheme/target

It works:

screenshot 2017-03-09 21 39 16

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 9, 2017
@mkonicek
Copy link
Contributor Author

Works locally and tests passed on Travis.

@facebook-github-bot shipit-ninja

@facebook-github-bot
Copy link
Contributor

Normally, mkonicek, someone else should review and ship your pull request. However, we will trust that you know what you are doing. Shipping!

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Mar 10, 2017
@facebook-github-bot
Copy link
Contributor

@mkonicek has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants