Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix tvOS and podspec builds #12866

Closed
wants to merge 1 commit into from
Closed

Try to fix tvOS and podspec builds #12866

wants to merge 1 commit into from

Conversation

mkonicek
Copy link
Contributor

@mkonicek mkonicek commented Mar 10, 2017 •
edited
Loading

Test plan:

  • Tested locally that UIExplorer compiles for iOS and tvOS targets.
  • Travis tests.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 10, 2017
@mkonicek mkonicek changed the title Try to fix tvOS and podspec builds [DO NOT MERGE BEFORE TRAVIS TESTS PASS] Try to fix tvOS and podspec builds Mar 10, 2017
@mkonicek mkonicek changed the title [DO NOT MERGE BEFORE TRAVIS TESTS PASS] Try to fix tvOS and podspec builds Try to fix tvOS and podspec builds Mar 10, 2017
@mkonicek
Copy link
Contributor Author

This fixes tvOS and podspec test. Investigating the e2e failure separately.

@facebook-github-bot shipit-ninja

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Mar 10, 2017
@facebook-github-bot
Copy link
Contributor

@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkonicek @facebook-github-bot