Fix cxx bridge headers when archiving #13008
Conversation
facebook-github-bot
added
the
CLA Signed
|
I believe @mhorowitz is landing changes similar to this internally right now. Ping me if there's still stuff wrong after that. |
|
Can you rebase past ba149d7 and see if there's anything missing? |
janicduplessis
force-pushed
the
cxx-bridge-archive
branch
from
63af50b
to
4a3b553
Compare
|
@javache Updated with the recent changes, we still need to move some headers to the 'project' section instead of 'private' or 'public' so archiving works properly. |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: There were some headers that were in the `public` or `private` section instead of `project` this causes headers to be included in archives and prevent it from being able to be uploaded to the app store. This fixes it by using only `project` headers and copy files like we use in other places. Also fixes a file that was moved and not updated in ReactCxx.xcodeproj. **Test plan** Tested that I am now able to upload an archive on the app store. Closes facebook#13008 Differential Revision: D4779894 Pulled By: javache fbshipit-source-id: 6e36e925cc3fc03c095c9f1872eb5a45b7f0d78c
react-native-bot
removed
the
Import Started
There were some headers that were in the
publicorprivatesection instead ofprojectthis causes headers to be included in archives and prevent it from being able to be uploaded to the app store. This fixes it by using onlyprojectheaders and copy files like we use in other places.Also fixes a file that was moved and not updated in ReactCxx.xcodeproj.
Test plan
Tested that I am now able to upload an archive on the app store.