Change indentation of package.json including Jest to 2 spaces #13099

ykzts · 2017-03-23T01:50:56Z

Thanks for submitting a PR! Please read these instructions carefully:

Explain the motivation for making this change.
Provide a test plan demonstrating that the code is solid.
Match the code formatting of the rest of the codebase.
Target the master branch, NOT a "stable" branch.

Motivation (required)

Indentation of package.json including Jest is a hard tab. Since package.json generated by npm has two spaces, I want to make it the same.

Test Plan (required)

Next Steps

Sign the CLA, if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

janicduplessis · 2017-03-24T01:31:17Z

local-cli/init/init.js

@@ -113,7 +113,7 @@ function addJestToPackageJson(destinationRoot) {
  packageJSON.jest = {
    preset: 'react-native'
  };
-  fs.writeFileSync(packageJSONPath, JSON.stringify(packageJSON, null, '\t'));
+  fs.writeFileSync(packageJSONPath, JSON.stringify(packageJSON, null, '  '));


You can pass 2 instead of 2 space characters in the 3rd param of JSON.stringify. It will make it a bit clearer.

Thank you review comment! It has changed. 99756a1

janicduplessis · 2017-03-24T16:11:52Z

Thanks for the PR!

@facebook-github-bot shipit

facebook-github-bot · 2017-03-24T16:12:21Z

@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ykzts · 2017-03-29T23:14:47Z

@janicduplessis There is "requested changes", but is there anything else you can fix?

janicduplessis · 2017-03-29T23:19:47Z

No just forgot to change that, looks like the import failed I'll try again.

janicduplessis · 2017-03-29T23:19:58Z

@facebook-github-bot shipit

facebook-github-bot · 2017-03-29T23:21:01Z

@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ykzts · 2017-03-30T00:46:04Z

@janicduplessis thx! ❤️

facebook-github-bot · 2017-04-03T20:39:24Z

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2017-08-13T17:02:17Z

@ykzts I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

facebook-github-bot · 2017-09-13T17:02:20Z

@ykzts I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

janicduplessis · 2017-09-14T01:14:08Z

@shergin Could you ship this

facebook-github-bot · 2017-09-14T16:11:04Z

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2017-09-15T05:48:14Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

facebook-github-bot · 2017-09-19T20:59:15Z

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2017-10-15T17:03:37Z

@ykzts I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

janicduplessis · 2017-10-15T17:07:59Z

@facebook-github-bot shipit

facebook-github-bot

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch.  Indentation of package.json including Jest is a hard tab. Since package.json generated by npm has two spaces, I want to make it the same.  ![package.json diff](https://cloud.githubusercontent.com/assets/12539/24228268/80421416-0fb6-11e7-9af3-d034c1756379.png) Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: https://travis-ci.org/facebook/react-native [4]: http://circleci.com/gh/facebook/react-native [5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests Closes facebook/react-native#13099 Differential Revision: D4770208 Pulled By: ericnakagawa fbshipit-source-id: 13f91068e40610473cd7b65e182a0fdc59af03ba

Change indentation of package.json including Jest to 2 spaces

0bce16f

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 23, 2017

janicduplessis suggested changes Mar 24, 2017

View reviewed changes

Change JSON.stringify arguments ' ' -> 2

99756a1

janicduplessis approved these changes Mar 29, 2017

View reviewed changes

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Apr 3, 2017

Merge branch 'master' into indent-2-space

a7f15fc

shergin added the Tooling label May 29, 2017

Merge branch 'master' into indent-2-space

84dbb80

Merge branch 'master' into indent-2-space

3c2a39b

Merge branch 'master' into indent-2-space

ef692e7

facebook-github-bot added GH Review: accepted and removed GH Review: review-needed labels Sep 14, 2017

Merge branch 'master' into indent-2-space

ffd9be2

facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 15, 2017

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 19, 2017

Merge branch 'master' into indent-2-space

02a82a7

facebook-github-bot approved these changes Oct 15, 2017

View reviewed changes

facebook-github-bot closed this in d980632 Oct 15, 2017

ykzts deleted the indent-2-space branch October 15, 2017 23:22

hramos added the Merged This PR has been merged. label Mar 8, 2019

react-native-bot removed the Import Started This pull request has been imported. This does not imply the PR has been approved. label Mar 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change indentation of package.json including Jest to 2 spaces #13099

Change indentation of package.json including Jest to 2 spaces #13099

ykzts commented Mar 23, 2017 •

edited

Loading

janicduplessis Mar 24, 2017

ykzts Mar 24, 2017 •

edited

Loading

janicduplessis commented Mar 24, 2017

facebook-github-bot commented Mar 24, 2017

ykzts commented Mar 29, 2017

janicduplessis commented Mar 29, 2017

janicduplessis commented Mar 29, 2017

facebook-github-bot commented Mar 29, 2017

ykzts commented Mar 30, 2017

facebook-github-bot commented Apr 3, 2017

facebook-github-bot commented Aug 13, 2017

facebook-github-bot commented Sep 13, 2017

janicduplessis commented Sep 14, 2017

facebook-github-bot commented Sep 14, 2017

facebook-github-bot commented Sep 15, 2017

facebook-github-bot commented Sep 19, 2017

facebook-github-bot commented Oct 15, 2017

janicduplessis commented Oct 15, 2017

facebook-github-bot left a comment

Change indentation of package.json including Jest to 2 spaces #13099

Change indentation of package.json including Jest to 2 spaces #13099

Conversation

ykzts commented Mar 23, 2017 • edited Loading

Motivation (required)

Test Plan (required)

Next Steps

janicduplessis Mar 24, 2017

Choose a reason for hiding this comment

ykzts Mar 24, 2017 • edited Loading

Choose a reason for hiding this comment

janicduplessis commented Mar 24, 2017

facebook-github-bot commented Mar 24, 2017

ykzts commented Mar 29, 2017

janicduplessis commented Mar 29, 2017

janicduplessis commented Mar 29, 2017

facebook-github-bot commented Mar 29, 2017

ykzts commented Mar 30, 2017

facebook-github-bot commented Apr 3, 2017

facebook-github-bot commented Aug 13, 2017

facebook-github-bot commented Sep 13, 2017

janicduplessis commented Sep 14, 2017

facebook-github-bot commented Sep 14, 2017

facebook-github-bot commented Sep 15, 2017

facebook-github-bot commented Sep 19, 2017

facebook-github-bot commented Oct 15, 2017

janicduplessis commented Oct 15, 2017

facebook-github-bot left a comment

Choose a reason for hiding this comment

ykzts commented Mar 23, 2017 •

edited

Loading

ykzts Mar 24, 2017 •

edited

Loading