Stop yarn error message appearing for Windows users of local-cli #13355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
@hramos thanks for importing! OSS tests are passing, and it looks like it can still be rebased on top of master. Are you able to tell me what failed on the import? (cc @ericvicenti as oncall) |
|
Looks like a flaky internal test has been blocking it. Giving it another try. |
ide
pushed a commit
that referenced
this pull request
Apr 7, 2017
Summary: On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken. From what I can tell this is what happens: * [`local-cli/util/yarn.js` does not ignore stderr on Windows](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/yarn.js#L25) * [`local-cli/util/PackageManager.js` calls the above function when it's require'd](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/PackageManager.js#L20) For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh Closes #13355 Differential Revision: D4848084 Pulled By: hramos fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
ide
pushed a commit
that referenced
this pull request
Apr 7, 2017
Summary: On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken. From what I can tell this is what happens: * [`local-cli/util/yarn.js` does not ignore stderr on Windows](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/yarn.js#L25) * [`local-cli/util/PackageManager.js` calls the above function when it's require'd](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/PackageManager.js#L20) For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh Closes #13355 Differential Revision: D4848084 Pulled By: hramos fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken. From what I can tell this is what happens: * [`local-cli/util/yarn.js` does not ignore stderr on Windows](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/yarn.js#L25) * [`local-cli/util/PackageManager.js` calls the above function when it's require'd](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/PackageManager.js#L20) For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh Closes facebook#13355 Differential Revision: D4848084 Pulled By: hramos fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken. From what I can tell this is what happens: * [`local-cli/util/yarn.js` does not ignore stderr on Windows](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/yarn.js#L25) * [`local-cli/util/PackageManager.js` calls the above function when it's require'd](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/PackageManager.js#L20) For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh Closes facebook/react-native#13355 Differential Revision: D4848084 Pulled By: hramos fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken.
From what I can tell this is what happens:
local-cli/util/yarn.jsdoes not ignore stderr on Windowslocal-cli/util/PackageManager.jscalls the above function when it's require'dFor Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays whenever local-cli requires PackageManager.js (which appears to be most of the time?).
Further, as far as I can tell there's no need to have this shell invocation happen when the module is loaded. It can be deferred to run only when we actually need to determine whether to use npm or yarn.
Test Plan
I've manually tested that the yarnVersion assignment behaves correctly on Mac and Windows, with yarn available and without. This doesn't seem like a clear opportunity for a regression test, as it's a small cosmetic problem.