Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README Examples section for RNTester #14229

Closed
wants to merge 1 commit into from

Conversation

brentvatne
Copy link
Collaborator

@brentvatne brentvatne commented May 27, 2017

Motivation

The Examples directory no longer exists and the instructions in this part of the README were stale.

Test Plan

Follow the instructions to run RNTester on iOS and Android

(this actually fails for me currently on Android, but I believe the instructions are correct and the failure is related to something else)

Closes #14222

The Examples directory no longer exists and the instructions in this part of the README were stale
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels May 27, 2017
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 28, 2017
@facebook-github-bot
Copy link
Contributor

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@TrustDec
Copy link

hi! Tried to run RNTester. The project doesnt compile for ios. It gives me a boost/iterator/iterator_adaptor.hpp file not found

@javache javache deleted the readme-examples-rntester branch May 31, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants