Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RCTTVRemoteHandler.m #15783

Closed
wants to merge 1 commit into from
Closed

Update RCTTVRemoteHandler.m #15783

wants to merge 1 commit into from

Conversation

iegik
Copy link

@iegik iegik commented Sep 4, 2017

Want to fix build on 0.48.1

According by comment #13198 (comment) - will fix building project.

To make React Native play nicely with our internal build infrastructure we need to properly namespace all of our header includes.

Where previously you could do #import "RCTBridge.h", you must now write this as #import <React/RCTBridge.h>. If your xcode project still has a custom header include path, both variants will likely continue to work, but for new projects, we're defaulting the header include path to $(BUILT_PRODUCTS_DIR)/usr/local/include, where the React and CSSLayout targets will copy a subset of headers too. To make Xcode copy headers phase work properly, you may need to add React as an explicit dependency to your app's scheme and disable "parallelize build".

Test Plan

Build test app, which uses this part. Build should pass.

@iegik iegik requested a review from shergin as a code owner September 4, 2017 11:21
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 4, 2017
@pull-bot
Copy link

pull-bot commented Sep 4, 2017

Attention: @shergin

Generated by 🚫 dangerJS

@hramos
Copy link
Contributor

hramos commented Sep 8, 2017

Do you have a test plan?

@iegik
Copy link
Author

iegik commented Sep 9, 2017

Did You ever seen Braking Changes at 0.40.0 ? https://github.com/facebook/react-native/releases/tag/v0.40.0
Well done. You did it - You broke it.

@facebook-github-bot
Copy link
Contributor

@iegik I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@stale
Copy link

stale bot commented Dec 18, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 18, 2017
@stale stale bot closed this Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants