Fix slider colors in Android #16053
Closed
Fix slider colors in Android #16053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
michalchudziak
pushed a commit
to michalchudziak/react-native-slider
that referenced
this pull request
Feb 8, 2019
Summary:
Hey !
I noticed that the `minimumTrackTintColor` and `maximumTrackTintColor` are exchanged in iOS and Android.
In iOS, `minimumTrackTintColor` is the left color and `maximumTrackTintColor` is the right color.
In Android, `minimumTrackTintColor` is the right color and `maximumTrackTintColor` is the left color.
With this code :
```jsx
<Slider
style={{ width: 300 }}
minimumTrackTintColor="red"
maximumTrackTintColor="blue"
/>
```
|iOS|Android|
|----|----|
|||
|iOS|Android|
|----|----|
| (same)||
Closes facebook/react-native#16053
Differential Revision: D5910299
Pulled By: shergin
fbshipit-source-id: 74851e4cc6d54f72ea2755200e26b0d921890b48
james-watkin
added a commit
to james-watkin/react-native-slider
that referenced
this pull request
Dec 28, 2021
|](https://user-images.githubusercontent.com/17292331/30700555-2b8ae828-9ee8-11e7-94a3-f1d3adee7fd5.png)||){kind=link}
|){kind=link}
Summary:
Hey !
I noticed that the `minimumTrackTintColor` and `maximumTrackTintColor` are exchanged in iOS and Android.
In iOS, `minimumTrackTintColor` is the left color and `maximumTrackTintColor` is the right color.
In Android, `minimumTrackTintColor` is the right color and `maximumTrackTintColor` is the left color.
With this code :
```jsx
<Slider
style={{ width: 300 }}
minimumTrackTintColor="red"
maximumTrackTintColor="blue"
/>
```
|iOS|Android|
|----|----|
|||
|iOS|Android|
|----|----|
| (same)||
Closes facebook/react-native#16053
Differential Revision: D5910299
Pulled By: shergin
fbshipit-source-id: 74851e4cc6d54f72ea2755200e26b0d921890b48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
I noticed that the
minimumTrackTintColorandmaximumTrackTintColorare exchanged in iOS and Android.In iOS,
minimumTrackTintColoris the left color andmaximumTrackTintColoris the right color.In Android,
minimumTrackTintColoris the right color andmaximumTrackTintColoris the left color.With this code :
Before
After