-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade connect #16380
[WIP] Upgrade connect #16380
Conversation
To supress below warning while installation warning connect@2.30.2: connect 2.x series is deprecated
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks for the PR! Could you just update the test plan to explain how you tested that it still works after updating connect, it's a major version bumb so there could be breaking changes. I'm not sure where we use this dependency but you could grep the codebase and make sure to test those features rapidly. |
Thanks for your comment! |
Have you tried it before submitting the PR? Because using ´yarn resolutions´ I was able to try to use |
@yuya-takeyama I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
What's preventing this from being landed? |
Let me close this for now. |
Motivation
To suppress below warning while installation
Test Plan
Have no idea as of now.
CI only?
Release Notes
[INTERNAL] [MINOR] [package.json] - Upgrade connect to v3.6.5