Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[general][enhancement] Move JS-native version check to its own module + unit tests + prefix Obj-C macro w/RCT #16403

Closed
wants to merge 1 commit into from
Closed

[general][enhancement] Move JS-native version check to its own module + unit tests + prefix Obj-C macro w/RCT #16403

wants to merge 1 commit into from

Commits on Oct 16, 2017

  1. Move JS-native version check to its own module + unit tests + prefix … 

    …Obj-C macro w/RCT

- The version check that ensures the JS and native versions match is now in its own module for two reasons: it is easier to test and it allows react-native-windows to override just this module to implement its own version check (ex: more advanced checks for RNW-specific code).
- Added unit tests for the version checking to specify its behavior more clearly, including parity between dev and prod to avoid prod-only behavior and mitigate SEVs.
- Prefixed the Obj-C `#define` with `RCT_` to conform with other RN globals.

Test Plan: Ran `yarn jest` to run all tests. Compiled iOS app and launched it, which runs the version check.
    @ide
    ide committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    80883f7 View commit details
    Browse the repository at this point in the history