Link both iOS and tvOS libraries with react-native link (fix #13783) #17084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
the
CLA Signed
eslint-bot
reviewed
Dec 8, 2017
| @@ -31,12 +32,31 @@ module.exports = function registerNativeModuleIOS(dependencyConfig, projectConfi | |||
| path.relative(projectConfig.sourceDir, dependencyConfig.projectPath) | |||
| ); | |||
|
|
|||
| const targets = getTargets(project); | |||
|
|
|||
There was a problem hiding this comment.
no-trailing-spaces: Trailing spaces not allowed.
|
Closing this, as I've provided a better PR for this issue at #17231 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix issues with the react-native CLI when linking iOS and tvOS libraries to a project created with
react-native init. (#13783)Test Plan
Verified the changes against test project at https://github.com/dlowder-salesforce/react-native-link-test. Both
react-native link react-native-svgandreact-native unlink react-native-svgwork correctly on this project. Also modified one of the local CLI unit tests to make sure that CI passes.Release Notes
[CLI]
react-native linkhas been fixed to correctly link iOS and tvOS targets.[IOS]
react-native linkhas been fixed to correctly link iOS and tvOS targets.