Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Added progress updates for all XMLHttpRequest upload types / fix crash on closed connection #17312

Closed
wants to merge 3 commits into from
Closed

[Android] Added progress updates for all XMLHttpRequest upload types / fix crash on closed connection #17312

wants to merge 3 commits into from

Commits on Jan 26, 2018

  1. [Android] Added progress updates for all XMLHttpRequest upload types 

    Previously, only form-data request bodies emitted upload progress updates. Now,
other request body types will also emit updates.

Addresses issues: 11853/15724
    @allengleyzer
    allengleyzer committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    0623a61 View commit details
    Browse the repository at this point in the history

  2. [NetworkingModuleTest] Mock classes for testSuccessfulPostRequest 

    Fixes UnsatisfiedLinkError while running unit test
    @allengleyzer
    allengleyzer committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    5c1e626 View commit details
    Browse the repository at this point in the history

  3. [Android] Replaced ForwardingSink with OutputStream to fix progress 

    Using a ForwardingSink, an IllegalStateException was thrown in Okio's
RealBufferedSink when attempting to write to a sink that was closed.
Additionally, it did not send updates for non-input stream request bodies.
Replacing with an OutputStream-based sink prevents the crash by throwing an
IOException instead, and fixes the progress updates. Also, now get the content
length before writing to avoid incorrect total size for input streams.
Addresses issues: 10423/11016.
    @allengleyzer
    allengleyzer committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    e0d91bf View commit details
    Browse the repository at this point in the history