Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwipeableFlatList] Fix #16685, fix opening rows doesn't close on swipe left a new row. #17668

Closed
wants to merge 2 commits into from
Closed

[SwipeableFlatList] Fix #16685, fix opening rows doesn't close on swipe left a new row. #17668

wants to merge 2 commits into from

Conversation

zongwan
Copy link
Contributor

@zongwan zongwan commented Jan 19, 2018

Motivation

Fix #16685

According to acc1edd

Test Plan

Swipe two different rows and it will look great.

Related PRs

#16682

[CLOSED for reducing commits ] #17663

Release Notes

[ANDROID] [BUGFIX] [SwipeableFlatList] - fix opening rows doesn't close on swipe left a new row.
[IOS] [BUGFIX] [SwipeableFlatList] - fix opening rows doesn't close on swipe left a new row.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Jan 19, 2018
@facebook-github-bot
Copy link
Contributor

@zongwan I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@zongwan
Copy link
Contributor Author

zongwan commented Feb 19, 2018

@sahrens

@sdwilsh sdwilsh removed the cla signed label Mar 1, 2018
@react-native-bot react-native-bot added Android Ran Commands One of our bots successfully processed a command. labels Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Ran Commands One of our bots successfully processed a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][SwipeableFlatList] First item not updated for the first time. Second, third... OK
5 participants