Fix DynamicFromMap object pool synchronization #17842

haitaoli · 2018-02-02T18:32:08Z

Motivation

DynamicFromMap internally uses SimplePool object to recycle dynamic prop objects. But the pool is not multi-thread safe. Currently the most used dynamic props are size props such as left, paddingVertical, marginTop and so on. These props are only accessed from the layout thread so the pool works fine. If a dynamic prop is needed in UI thread, then the two threads can access the same pool object and cause random errors. This PR make the pool object thread local to avoid synchronization. After this change there are two pool objects created in the process.

Test Plan

Tested in official Airbnb app after updating accessibilityComponentType to be dynamic.

Related PRs

Once this is merged, I'll send another PR to support "disabled" state in accessibilityComponentType.

Release Notes

[ANDROID] [BUGFIX] [DynamicFromMap] - Fix a crash caused by dynamic props.

facebook-github-bot · 2018-03-05T18:05:42Z

@haitaoli I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

haitaoli · 2018-03-06T00:02:26Z

Rebased

facebook-github-bot · 2018-04-05T17:04:45Z

@haitaoli I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

hey99xx · 2018-10-03T05:05:03Z

Our team also noticed this bug after inspecting a crash in production. We actually got a very similar stacktrace to #19141 starting with

Caused by java.lang.ArrayIndexOutOfBoundsException: length=10; index=-1
       at android.support.v4.util.Pools$SimplePool.release(Pools.java:120)
       at com.facebook.react.bridge.DynamicFromMap.recycle(DynamicFromMap.java:42)

only the line number at DynamicFromMap class is now 40 instead of 42 (running more recent version of RN). So this is an obviously an issue that needs to be fixed, either with ThreadLocal usage as in this PR or by using Pools.SynchronizedPool<DynamicFromMap>.

@haitaoli Is this PR abandoned (probably since AirBnb is leaving RN) or will you continue working on it? I think the same fix should also be done for DynamicFromArray class for correctness, even if it's not an issue yet.

haitaoli · 2018-10-03T16:42:03Z

@hey99xx I don't think anyone will review and merge this PR, since this probably doesn't affect FB's own apps. I have another PR to fix a bug on iOS and that's not going anywhere either. As you mentioned Airbnb is deprecating RN so I won't be pushing this fix to get merged. It might be easier for you to fork RN and merge any fixes you need.

janicduplessis · 2018-10-13T20:37:54Z

@haitaoli Sorry this PR got unnoticed. We actually hit an issue caused by this in react-native-svg. Looks good to me so we can go ahead and ship this.

janicduplessis · 2018-10-13T20:38:31Z

@facebook-github-bot shipit

janicduplessis · 2018-10-13T20:38:55Z

@haitaoli Can you link me the iOS PR, I can have a look.

facebook-github-bot

janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

haitaoli · 2018-10-13T22:08:25Z

@janicduplessis thanks! Here is the iOS PR I mentioned: #17230

react-native-bot · 2018-10-14T00:45:04Z

@haitaoli merged commit b0d68c0 into facebook:master.

Summary: DynamicFromMap internally uses SimplePool object to recycle dynamic prop objects. But the pool is not multi-thread safe. Currently the most used dynamic props are size props such as left, paddingVertical, marginTop and so on. These props are only accessed from the layout thread so the pool works fine. If a dynamic prop is needed in UI thread, then the two threads can access the same pool object and cause random errors. This PR make the pool object thread local to avoid synchronization. After this change there are two pool objects created in the process. Tested in official Airbnb app after updating accessibilityComponentType to be dynamic. Once this is merged, I'll send another PR to support "disabled" state in `accessibilityComponentType`. [ANDROID] [BUGFIX] [DynamicFromMap] - Fix a crash caused by dynamic props. Pull Request resolved: facebook#17842 Differential Revision: D10374238 Pulled By: hramos fbshipit-source-id: 7ebf89c5abf06bd5fb43b205348ba4dc7e19517d

Summary: DynamicFromMap internally uses SimplePool object to recycle dynamic prop objects. But the pool is not multi-thread safe. Currently the most used dynamic props are size props such as left, paddingVertical, marginTop and so on. These props are only accessed from the layout thread so the pool works fine. If a dynamic prop is needed in UI thread, then the two threads can access the same pool object and cause random errors. This PR make the pool object thread local to avoid synchronization. After this change there are two pool objects created in the process. Tested in official Airbnb app after updating accessibilityComponentType to be dynamic. Once this is merged, I'll send another PR to support "disabled" state in `accessibilityComponentType`. [ANDROID] [BUGFIX] [DynamicFromMap] - Fix a crash caused by dynamic props. Pull Request resolved: #17842 Differential Revision: D10374238 Pulled By: hramos fbshipit-source-id: 7ebf89c5abf06bd5fb43b205348ba4dc7e19517d

Summary: DynamicFromMap internally uses SimplePool object to recycle dynamic prop objects. But the pool is not multi-thread safe. Currently the most used dynamic props are size props such as left, paddingVertical, marginTop and so on. These props are only accessed from the layout thread so the pool works fine. If a dynamic prop is needed in UI thread, then the two threads can access the same pool object and cause random errors. This PR make the pool object thread local to avoid synchronization. After this change there are two pool objects created in the process. Tested in official Airbnb app after updating accessibilityComponentType to be dynamic. Once this is merged, I'll send another PR to support "disabled" state in `accessibilityComponentType`. [ANDROID] [BUGFIX] [DynamicFromMap] - Fix a crash caused by dynamic props. Pull Request resolved: facebook#17842 Differential Revision: D10374238 Pulled By: hramos fbshipit-source-id: 7ebf89c5abf06bd5fb43b205348ba4dc7e19517d

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Feb 2, 2018

sdwilsh removed the cla signed label Mar 1, 2018

Fix DynamicFromMap object pool synchronization

052d9fb

haitaoli force-pushed the android-fix-synchronization branch from c9a76e3 to 052d9fb Compare March 6, 2018 00:01

hramos added Android and removed Android labels Mar 13, 2018

react-native-bot added Bug Fix 🐛 Ran Commands One of our bots successfully processed a command. labels Mar 16, 2018

janicduplessis removed the Android 🤖 label Mar 19, 2018

Almouro mentioned this pull request Oct 12, 2018

Android crash: This dynamic value has been recycled software-mansion/react-native-svg#806

Closed

janicduplessis approved these changes Oct 13, 2018

View reviewed changes

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Oct 13, 2018

facebook-github-bot approved these changes Oct 13, 2018

View reviewed changes

facebook-github-bot closed this in b0d68c0 Oct 14, 2018

facebook locked as resolved and limited conversation to collaborators Oct 14, 2018

react-native-bot added the Merged This PR has been merged. label Oct 14, 2018

hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019

react-native-bot added the Bug label May 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix DynamicFromMap object pool synchronization #17842

Fix DynamicFromMap object pool synchronization #17842

haitaoli commented Feb 2, 2018 •

edited

Loading

facebook-github-bot commented Mar 5, 2018

haitaoli commented Mar 6, 2018

facebook-github-bot commented Apr 5, 2018

hey99xx commented Oct 3, 2018 •

edited

Loading

haitaoli commented Oct 3, 2018

janicduplessis commented Oct 13, 2018

janicduplessis commented Oct 13, 2018

janicduplessis commented Oct 13, 2018

facebook-github-bot left a comment

haitaoli commented Oct 13, 2018

react-native-bot commented Oct 14, 2018

Fix DynamicFromMap object pool synchronization #17842

Fix DynamicFromMap object pool synchronization #17842

Conversation

haitaoli commented Feb 2, 2018 • edited Loading

Motivation

Test Plan

Related PRs

Release Notes

facebook-github-bot commented Mar 5, 2018

haitaoli commented Mar 6, 2018

facebook-github-bot commented Apr 5, 2018

hey99xx commented Oct 3, 2018 • edited Loading

haitaoli commented Oct 3, 2018

janicduplessis commented Oct 13, 2018

janicduplessis commented Oct 13, 2018

janicduplessis commented Oct 13, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

haitaoli commented Oct 13, 2018

react-native-bot commented Oct 14, 2018

haitaoli commented Feb 2, 2018 •

edited

Loading

hey99xx commented Oct 3, 2018 •

edited

Loading