Fix bug rows doesn't close on scroll in a SwipeableFlatList

[Freddy03h]

Motivation

Fix bug SwipeableRows doesn't close on Scroll in a SwipeableFlatList

Test Plan

Use a SwipeableFlatList with multiple rows, open one of them, then scroll.
Open row should close on scroll.

Release Notes

[GENERAL] [BUGFIX] [SwipeableFlatList] - Fix rows doesn't close on scroll

[vonovak]

In other words, this will re-render the entire list on scroll if some row is open. While this works, I daresay it is just a workaround and the true bugfix lays in making sure the SwipableRow gets the correct isOpen prop in isOpen={key === this.state.openRowKey}.

[Freddy03h]

But renderItem is called only if FlatList data or extraData are changed.
That's the bug. If you want to use this.state in the render props function renderItem you have to give it to extraData.
It's the way FlatList work, I don't know if there is an other solution.

[Freddy03h]

Any update on this ?

[facebook-github-bot]

@Freddy03h I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[Freddy03h]

Maybe @tomasreimers can be a reviewer ? Thanks.

[facebook-github-bot]

tomasreimers has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was closed by @Freddy03h in 16b3783.

Once this commit is added to a release, you will see the corresponding version tag below the description at 16b3783. If the commit has a single master tag, it is not yet part of a release.