Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add Node 10 job to workflow #19299

Closed
wants to merge 2 commits into from
Closed

[CI] Add Node 10 job to workflow #19299

wants to merge 2 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented May 16, 2018 •
edited
Loading

Adds a new workflow that runs JavaScript tests on Node 10. Fixes #19229.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2018
@react-native-bot react-native-bot added Missing Test Plan This PR appears to be missing a test plan. Core Team Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels May 16, 2018
@hramos hramos mentioned this pull request May 17, 2018
Closed
2 tasks
@gengjiawen
Copy link
Contributor

Jest need to make a new release to support node 10, jestjs/jest#6196.

@facebook-github-bot
Copy link
Contributor

@hramos I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 20, 2018
facebook-github-bot
facebook-github-bot approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos hramos changed the title WIP: Add Node 10 job to workflow [CI] Add Node 10 job to workflow Aug 20, 2018
@react-native-bot
Copy link
Collaborator

This pull request was closed by @hramos in 91bba30.

Once this commit is added to a release, you will see the corresponding version tag below the description at 91bba30. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 21, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 21, 2018
@hramos hramos deleted the node-10 branch August 21, 2018 19:28
hramos added a commit that referenced this pull request Aug 22, 2018
@hramos
WIP: Add Node 10 job to workflow
d286ff9 
Summary: Pull Request resolved: #19299

Differential Revision: D9413583

Pulled By: hramos

fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
aleclarson pushed a commit to aleclarson/react-native that referenced this pull request Sep 16, 2018
@hramos @aleclarson
WIP: Add Node 10 job to workflow
44a7f25 
Summary: Pull Request resolved: facebook#19299

Differential Revision: D9413583

Pulled By: hramos

fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@hramos @facebook-github-bot
WIP: Add Node 10 job to workflow
59c5c05 
Summary: Pull Request resolved: facebook#19299

Differential Revision: D9413583

Pulled By: hramos

fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@hramos
WIP: Add Node 10 job to workflow
fe5872a 
Summary: Pull Request resolved: facebook#19299

Differential Revision: D9413583

Pulled By: hramos

fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Missing Test Plan This PR appears to be missing a test plan.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hramos @gengjiawen @facebook-github-bot @react-native-bot