Libraries/Geolocation/RCTLocationObserver.m 208-222 line commented. I… #19554
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
react-native-bot
added
✅Test Plan
Missing Changelog
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
You should remove the code rather than comment it out. Your test plan seems incomplete. How did you test that this fixes the issue? |
|
@sadeghipour I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
react-native-bot
added
Missing Test Plan
|
Closing after several months without a test plan. Feel free to send another PR with a description of how the change was tested, if you're interested in landing this change. |
Fixes #19057
Apple stopped accept applications without NSLocationAlwaysUsageDescription description in .plist file.
IOS Apple do not accepting apps without NSLocationAlwaysUsageDescription description.
navigator.geolocation.getCurrentPosition stop working after we add NSLocationAlwaysUsageDescription and NSLocationWhenInUseUsageDescription to plist.
Related PRs
https://facebook.github.io/react-native/docs/geolocation.html already update.