Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump RNTester targetSdkVersion to 26 #19905

Conversation

gengjiawen
Copy link
Contributor

Motivation
bump RNTester targetSdkVersion to 26

Test Plan
pass all current ci.

Related PRs
none

Release Notes
[GENERAL] [INTERNAL] [RNTester] - bump RNTester targetSdkVersion to 26

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2018
@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Jun 26, 2018
@janicduplessis
Copy link
Contributor

@gengjiawen Could you rebase on master to make sure Android CI passes

@gengjiawen gengjiawen force-pushed the RNTester/bump_target_sdk_version branch from cf6d035 to dd9aeac Compare June 27, 2018 21:16
@gengjiawen
Copy link
Contributor Author

@janicduplessis done.

@gengjiawen
Copy link
Contributor Author

It seems the ci is broken again in master branch ...

@dulmandakh
Copy link
Contributor

dulmandakh commented Jun 28, 2018

@gengjiawen I created a PR to set targetSdkVersion to 26, including RNTester app #19944

@rghorbani
Copy link

@gengjiawen Thanks but this already has been implemented. #19662

@gengjiawen gengjiawen closed this Jun 28, 2018
@gengjiawen gengjiawen deleted the RNTester/bump_target_sdk_version branch June 29, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants