add windows ci

[gengjiawen]

Motivation

Add windows ci

Test Plan

pass all current ci.

Related PRs

none

Release Notes

[GENERAL] [INTERNAL] [CI] - add windows ci

[gengjiawen]

cc @hramos

[matthargett]

I suggest doing appveyor-retry npm to make it resilient against intermittent network issues. I added this in the react-native-windows AppVeyor configuration to eliminate a not-uncommon source of flakiness. https://github.com/Microsoft/react-native-windows/blob/master/appveyor.yml#L40

You may also want to add appveyor-retry npm install npm@lts as the first command. We also did that to combat flakiness around the npm 5 era.

[matthargett]

Right now, the build doesn't get to npm test -- it fails on the gradle command, with the failure indicator saying :RNTester:android:app:bundleReleaseJsAndAssets FAILED.

Is that what we expect? Can we up the logging level so the error is more detailed and easier for users without a local Windows instance to reason about?

[matthargett]

I love how clean this is with things extracted into variables, btw. Great job! 🥇

[gengjiawen]

The failure is expected, since the windows issue still exists. Hopefully @rafeca can fix facebook/metro#181 today. The gradle error message in most case in sufficient.

[gengjiawen]

@hramos Can you enable appveyor for react native, I want to add the badge in README.md.

[hramos]

Enabled.

[gengjiawen]

@hramos I have updated README.md. Do you plan to merge this or after have the windows build fixed ?

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was closed by @gengjiawen in 1b2a552.

Once this commit is added to a release, you will see the corresponding version tag below the description at 1b2a552. If the commit has a single master tag, it is not yet part of a release.