Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] Add test case suggestion to PR template #21234

Closed
wants to merge 1 commit into from
Closed

[trivial] Add test case suggestion to PR template #21234

wants to merge 1 commit into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Sep 20, 2018

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 20, 2018
facebook-github-bot
facebook-github-bot approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot react-native-bot added Core Team Missing Test Plan This PR appears to be missing a test plan. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Sep 21, 2018
@react-native-bot
Copy link
Collaborator

@hramos merged commit c1f884e into facebook:master.

Once this commit is added to a release, you will see the corresponding version tag below the description at c1f884e. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 21, 2018
@hramos hramos deleted the prtemplate branch September 24, 2018 19:57
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@hramos @facebook-github-bot
Add test case suggestion to PR template
7586a43 
Summary: Pull Request resolved: facebook#21234

Differential Revision: D9982500

Pulled By: hramos

fbshipit-source-id: 585d4a8292ac7f53f26adf53a36e766a49fdc5b6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Missing Test Plan This PR appears to be missing a test plan.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hramos @react-native-bot @facebook-github-bot