StatusBar: Remove PropTypes #21293
Closed
StatusBar: Remove PropTypes #21293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
TheSavior
reviewed
Sep 24, 2018
| type DefaultProps = { | ||
| animated: boolean, | ||
| }; | ||
| type StatusBarProps = $ReadOnly<{| |
There was a problem hiding this comment.
I think I'd prefer if you just named these types Props. I believe that is consistent with all the other files
TheSavior
requested changes
Sep 24, 2018
| * The background color of the status bar. | ||
| * @platform android | ||
| */ | ||
| backgroundColor?: ?string, |
There was a problem hiding this comment.
When there are a bunch of Props that are supported on different platforms, I like doing this pattern:
type AndroidProps = //
type IOSProps = //
type Props = $ReadOnly<{|
...IOSProps,
...AndroidProps,
// shared props
|}>
There was a problem hiding this comment.
And also re-organized these
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@empyrical merged commit cd1d3ce into Once this commit is added to a release, you will see the corresponding version tag below the description at cd1d3ce. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Part of: react-native-community/discussions-and-proposals#29 This PR removes the remaining PropTypes from `StatusBar` and moves its flowtypes to its own definition. Pull Request resolved: facebook#21293 Differential Revision: D10012963 Pulled By: TheSavior fbshipit-source-id: 7fb4e416eb49e7860809a3e2aaf157590908687d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: react-native-community/discussions-and-proposals#29
This PR removes the remaining PropTypes from
StatusBarand moves its flowtypes to its own definition.Test Plan:
flow checkpasses for android and ios.Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Components/StatusBar/StatusBar.js] - Removed PropTypes