Update to Detox 9 #21570
Closed
Update to Detox 9 #21570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelset
added
the
🔩Test Infrastructure
facebook-github-bot
added
the
CLA Signed
Closed
3 tasks
There was a problem hiding this comment.
hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Closed
|
This should be landing soon. |
grabbou
pushed a commit
that referenced
this pull request
Oct 11, 2018
Summary: Updating to Detox 9 - this should help with better Xcode 10 support, and should fix #21539. I've updated to fixed `9.0.4` since it seems that each version is fairly different from the next, and I've followed the [migration guide](https://github.com/wix/detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-8xx-to-9xx) for the android native dependencies. Release Notes: [INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4 Pull Request resolved: #21570 Reviewed By: TheSavior Differential Revision: D10242373 Pulled By: RSNara fbshipit-source-id: bd29d554e0972f16d96b9b39b86c7143941d5b7c
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Updating to Detox 9 - this should help with better Xcode 10 support, and should fix facebook#21539. I've updated to fixed `9.0.4` since it seems that each version is fairly different from the next, and I've followed the [migration guide](https://github.com/wix/detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-8xx-to-9xx) for the android native dependencies. Release Notes: [INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4 Pull Request resolved: facebook#21570 Reviewed By: TheSavior Differential Revision: D10242373 Pulled By: RSNara fbshipit-source-id: bd29d554e0972f16d96b9b39b86c7143941d5b7c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to Detox 9 - this should help with better Xcode 10 support, and should fix #21539.
I've updated to fixed
9.0.4since it seems that each version is fairly different from the next, and I've followed the migration guide for the android native dependencies.Test Plan:
Run against CI. Should not affect other builds.
Release Notes:
[INTERNAL] [ENHANCEMENT] [DETOX] - Update to version 9.0.4