Fix: Add displayName to ActivityIndicator #22417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying 'Component' instead of 'ActivityIndicator'
facebook-github-bot
added
the
CLA Signed
|
Thanks for the fix! As you mentioned there aren't any tests that caught this. Would you like to try adding a simple jest test for ActivityIndicator that uses a snapshot test that would keep this problem from happening again? |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@TheSavior I added a basic Snapshot for ActivityIndicator that should catch regressions on this! |
|
Awesome, thanks! |
facebook-github-bot
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Michael Blanchard merged commit 53da585 into |
grabbou
pushed a commit
that referenced
this pull request
Dec 4, 2018
Summary: Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes #21937 (a little bit more than it was already fixed). Pull Request resolved: #22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4
kelset
pushed a commit
that referenced
this pull request
Dec 12, 2018
Summary: Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes #21937 (a little bit more than it was already fixed). Pull Request resolved: #22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Similar to facebook#21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes facebook#21937 (a little bit more than it was already fixed). Pull Request resolved: facebook#22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Similar to #21950, this adds displayName to
ActivityIndicator, so it displays the correct component name in snapshots instead ofComponent.Fixes #21937 (a little bit more than it was already fixed).
Test Plan:
yarn test - ActivityIndicator's - ActivityIndicator-test.js.snap should Show
Changelog/Release Notes:
[General] [Fixed] - Add displayName to ActivityIndicator for snapshots