Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change template to work with jest #23150

Closed
wants to merge 1 commit into from

Conversation

@Esemesek
Copy link
Contributor

Esemesek commented Jan 24, 2019

This change is required to make yarn test work in newly initialized project.

Why?

Jest@23 doesn't play well with new babel, so we need to install babel-core@^7.0.0-bridge.0 and change .babelrc to babel.config.js to make it work. This is a temporary change till jest releases stable 24 version.

Test Plan:

Already tested it locally using verdaccio to publish react-native and @react-native-community@cli locally.

cc. @grabbou @thymikee

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jan 24, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot

This comment has been minimized.

Copy link

pull-bot commented Jan 24, 2019

Warnings
⚠️

📋 Changelog - This PR appears to be missing Changelog. Please add a section called "changelog" and format it as explained in the contributing guidelines.

Generated by 🚫 dangerJS

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jan 24, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

thymikee left a comment

This should have been changed a long time ago, thanks! @grabbou once merged, please cherry-pick to 0.57 and 0.58

@vovkasm

This comment has been minimized.

Copy link
Contributor

vovkasm commented Jan 24, 2019

@thymikee 0.58 already contains the fix #23128 and it would be good to port it into 0.57 also.

Copy link

facebook-github-bot left a comment

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot

This comment has been minimized.

Copy link
Collaborator

react-native-bot commented Jan 25, 2019

@Esemesek merged commit 5218932 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 25, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
Summary:
This change is required to make `yarn test` work in newly initialized project.
`Jest@23` doesn't play well with new babel, so we need to install `babel-core@^7.0.0-bridge.0` and change `.babelrc` to `babel.config.js` to make it work. This is a temporary change till `jest` releases stable `24` version.
Pull Request resolved: facebook#23150

Differential Revision: D13811428

Pulled By: hramos

fbshipit-source-id: 8db6b9177cd31d4a1213fb44964b05f26982bdf2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.