Remove jest and jest-junit from runtime dependencies #23276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 06c13b3 pretend to update jest to new version, but also adds jest and jest-unit to runtime dependencies list (in addition to dev dependencies). This commit fixes this, by removing jest and jest-junit from runtime dependeincies.
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
|
@rafeca As one who initially changed runtime dependency, can you please help with this to be landed? |
cpojer
approved these changes
Feb 4, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This commit brought the following commits to 0.58-stable branch. Github UI was showing they were already part of the branch, where in fact, they were not. This was done to avoid confusion and bring it to sync. |
grabbou
pushed a commit
that referenced
this pull request
Feb 4, 2019
Summary: Commit 06c13b3 pretend to update jest to new version, but also adds jest and jest-junit to runtime dependencies list (in addition to dev dependencies). This commit fixes this, by removing jest and jest-junit from runtime dependeincies. As for motivation... story is short: 1. Updating RN 0.58.1 -> 0.58.3 I found that whole babel@6 infrastructure was returned to my `node_modules` (it is dangerous, because many tools like metro can found it and use it instead of babel@7). 2. It was because of this commit: 9d19ab0 that have 130 random files changed (and provides no meaning description). But it points to: b864e7e (which also provides no meaning description, why it was reverted?) And finally points to: 696bd89, which was a "sync with master" commit. Ok. So it was from master. 3. Then I checked that jest still in runtime dependencies on master and fixed that. Also I hope this will be cherry picked into 0.58-stable. [General] [Fixed] - Fix jest and jest-junit to be only development dependencies Pull Request resolved: #23276 Differential Revision: D13941275 Pulled By: cpojer fbshipit-source-id: a6f3377e670554b21f3ebd2f12d33e29d2969df1
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Commit 06c13b3 pretend to update jest to new version, but also adds jest and jest-junit to runtime dependencies list (in addition to dev dependencies). This commit fixes this, by removing jest and jest-junit from runtime dependeincies. As for motivation... story is short: 1. Updating RN 0.58.1 -> 0.58.3 I found that whole babel@6 infrastructure was returned to my `node_modules` (it is dangerous, because many tools like metro can found it and use it instead of babel@7). 2. It was because of this commit: 9d19ab0 that have 130 random files changed (and provides no meaning description). But it points to: b864e7e (which also provides no meaning description, why it was reverted?) And finally points to: 696bd89, which was a "sync with master" commit. Ok. So it was from master. 3. Then I checked that jest still in runtime dependencies on master and fixed that. Also I hope this will be cherry picked into 0.58-stable. [General] [Fixed] - Fix jest and jest-junit to be only development dependencies Pull Request resolved: facebook#23276 Differential Revision: D13941275 Pulled By: cpojer fbshipit-source-id: a6f3377e670554b21f3ebd2f12d33e29d2969df1
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Commit 06c13b3 pretend to update jest to new version, but also adds jest and jest-junit to runtime dependencies list (in addition to dev dependencies). This commit fixes this, by removing jest and jest-junit from runtime dependeincies. As for motivation... story is short: 1. Updating RN 0.58.1 -> 0.58.3 I found that whole babel@6 infrastructure was returned to my `node_modules` (it is dangerous, because many tools like metro can found it and use it instead of babel@7). 2. It was because of this commit: 9d19ab0 that have 130 random files changed (and provides no meaning description). But it points to: b864e7e (which also provides no meaning description, why it was reverted?) And finally points to: 696bd89, which was a "sync with master" commit. Ok. So it was from master. 3. Then I checked that jest still in runtime dependencies on master and fixed that. Also I hope this will be cherry picked into 0.58-stable. [General] [Fixed] - Fix jest and jest-junit to be only development dependencies Pull Request resolved: facebook#23276 Differential Revision: D13941275 Pulled By: cpojer fbshipit-source-id: a6f3377e670554b21f3ebd2f12d33e29d2969df1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commit 06c13b3 pretend to update jest
to new version, but also adds jest and jest-junit to runtime dependencies
list (in addition to dev dependencies).
This commit fixes this, by removing jest and jest-junit from runtime
dependeincies.
As for motivation... story is short:
node_modules(it is dangerous, because many tools like metro can found it and use it instead of babel@7).But it points to: b864e7e (which also provides no meaning description, why it was reverted?)
And finally points to: 696bd89, which was a "sync with master" commit. Ok. So it was from master.
Changelog
[General] [Fixed] - Fix jest and jest-junit to be only development dependencies
Test Plan
I'm already have this change in my fork of 0.58-stable branch, all worked as expected.