[Android] Check if mCurrentActivity is set according to LifecycleState #23336

RoJoHub · 2019-02-07T19:43:31Z

Summary

Issues: Related to #13439
react-native-website:Related to PR #792
solution: #13439 (comment)

When we integration with Existing Android Apps.and set LifecycleState is LifecycleState.RESUMED.
It's lead to mCurrentActivity is null .

At this time , the behave of set mCurrentActivity which is unexpectedly.

Changelog

[Android] [Fixed] - Check if mCurrentActivity is set according to LifecycleState

Test Plan

Everything should run as usual.And Fix this Bug #13439 .

Merge

RoJoHub · 2019-02-07T19:50:41Z

Also i am confused that setCurrentActivity is not be used.

If setupReactContextRunnable runs faster thanmaybeRecreateReactContextRunnable,the value of activity is null from now on.Because of setupReactContextRunnable and maybeRecreateReactContextRunnable are asynchronous.

matthargett

@cpojer this alternate approach should avoid the TTI impact mentioned in the internal review.

RoJoHub · 2019-02-07T19:55:50Z

@matthargett

I'm not change iOS.But ci is warming.--->ci/circleci: test_ios

RoJoHub · 2019-02-07T20:01:09Z

@matthargett
Also we should change doc of android.
integration-with-existing-apps

public class MyReactActivity extends Activity implements DefaultHardwareBackBtnHandler {
    private ReactRootView mReactRootView;
    private ReactInstanceManager mReactInstanceManager;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        mReactRootView = new ReactRootView(this);
        mReactInstanceManager = ReactInstanceManager.builder()
                .setApplication(getApplication())
+               .setCurrentActivity(this)
                .setBundleAssetName("index.android.bundle")
                .setJSMainModulePath("index")
                .addPackage(new MainReactPackage())
                .setUseDeveloperSupport(BuildConfig.DEBUG)
                .setInitialLifecycleState(LifecycleState.RESUMED)
                .build();
        // The string here (e.g. "MyReactNativeApp") has to match
        // the string in AppRegistry.registerComponent() in index.js
        mReactRootView.startReactApplication(mReactInstanceManager, "MyReactNativeApp", null);

        setContentView(mReactRootView);
    }

    @Override
    public void invokeDefaultOnBackPressed() {
        super.onBackPressed();
    }
}

hey99xx · 2019-02-14T10:57:48Z

I didn't review what's the actual bug, but I just want to point out that there are use cases of creating a ReactInstanceManager outside of an activity context. Requiring activity be set initially would break that use case.

For example in a brownfield app where not all activities are in RN, before the user navigates to a ReactActivity to speed things up, we can create ReactInstanceManager on the background, save it in an instance variable, then once the activity is launched we use that ReactInstanceManager already prepared.

hey99xx · 2019-02-14T11:06:03Z

Similarly I don't understand how HeadlessJsTaskService where you pass null for activity would work after this change. Does it rely on that ReactNativeHost will always be creating a ReactInstanceManager first with an activity and then HeadlessJsTaskService will reuse the same ReactInstanceManager? If so that may not always be true either.

RoJoHub · 2019-02-14T12:46:18Z

@hey99xx

Please observe its running order

    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        mReactRootView = new ReactRootView(this);
        mReactInstanceManager = ReactInstanceManager.builder()
                .setApplication(getApplication())
                .setBundleAssetName("index.android.bundle")
                .setJSMainModulePath("index")
                .addPackage(new MainReactPackage())
                .setUseDeveloperSupport(BuildConfig.DEBUG)
                .setInitialLifecycleState(LifecycleState.RESUMED)
                .build();
        // 注意这里的MyReactNativeApp必须对应“index.js”中的
        // “AppRegistry.registerComponent()”的第一个参数
        mReactRootView.startReactApplication(mReactInstanceManager, "MyReactNativeApp", null);

        setContentView(mReactRootView);
    }

startReactApplication ->
createReactContextInBackground ->
recreateReactContextInBackgroundInner ->
recreateReactContextInBackgroundFromBundleLoader ->
recreateReactContextInBackground ->
runCreateReactContextOnNewThread ->
mCreateReactContextThread ->
setupReactContext ->
moveReactContextToCurrentLifecycleState ->
moveToResumedLifecycleState(true) ->
currentContext.onHostResume(mCurrentActivity)

In moveToResumedLifecycleState(true) -> currentContext.onHostResume(mCurrentActivity), we will pass mCurrentActivity to currentContext, but what if mCurrentActivity is null at this time?

We can know that setupReactContext is asynchronous.
We set the value of mCurrentActivity through the onHostResume of ReactInstanceManager.

In the past, reactInstanceManager.builder() was not call setCurrentActivity.
So in ReactInstanceManager, the value of mCurrentActivity is always null, and only wait until mReactInstanceManager.onHostResume(this, this) is executed to set value of mCurrentActivity

Set the value of mCurrentActivity of mReactInstanceManager here.
Before this, the value of mCurrentActivity is null.

@Override
protected void onResume() {
    super.onResume();

    if (mReactInstanceManager != null) {
        mReactInstanceManager.onHostResume(this, this);
    }
}

Summary

Sometimes the moveToResumedLifecycleState in startReactApplication is executed faster than mReactInstanceManager.onHostResume(this, this);.
At this time, the value of mCurrentActivity is null.
So it will call currentContext.onHostResume(null)

private synchronized void moveToResumedLifecycleState(boolean force) {
        ...
        // at this time,the value of mCurrentActivity is null
        currentContext.onHostResume(mCurrentActivity);
        ...
    }

So the value obtained by other modules executing getCurrentActivity is null

public @Nullable Activity getCurrentActivity() {
    if (mCurrentActivity == null) {
      return null;
    }
    return mCurrentActivity.get();
  }

RoJoHub · 2019-02-14T12:54:45Z

@hey99xx

We are asynchronous to set the value of `mCurrentActivity` in `ReactInstanceManager`!!!!!!

Execute first

@Override
protected void onResume() {
    super.onResume();

    if (mReactInstanceManager != null) {
        mReactInstanceManager.onHostResume(this, this);
    }
}

Post execution

@Override
protected void onResume() {
    super.onResume();

    if (mReactInstanceManager != null) {
        mReactInstanceManager.onHostResume(this, this);
    }
}

RoJoHub · 2019-02-14T13:09:48Z

Two point to set `mCurrentActivity`

startReactApplication ->
createReactContextInBackground ->
recreateReactContextInBackgroundInner ->
recreateReactContextInBackgroundFromBundleLoader ->
recreateReactContextInBackground ->
runCreateReactContextOnNewThread ->
mCreateReactContextThread ->
setupReactContext ->
moveReactContextToCurrentLifecycleState ->
moveToResumedLifecycleState(true) ->
currentContext.onHostResume(mCurrentActivity)

and

@Override
protected void onResume() {
    super.onResume();

    if (mReactInstanceManager != null) {
        mReactInstanceManager.onHostResume(this, this);
    }
}

My English is very poor, please carefully observe the execution order and changes in mCurrentActivity.

hey99xx · 2019-02-14T19:18:52Z

I understand onHostResume is called with null and looks like a bug, but regardless of that you should attempt to fix a bug in a way considering other use cases:

For your flow:

moveReactContextToCurrentLifecycleState ->
moveToResumedLifecycleState(true) ->
currentContext.onHostResume(mCurrentActivity)

moveReactContextToCurrentLifecycleState will call moveToResumedLifecycleState only if it's at LifecycleState.RESUME state:

react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines 693 to 697 in be282b5

    
           private synchronized void moveReactContextToCurrentLifecycleState() { 
        
             if (mLifecycleState == LifecycleState.RESUMED) { 
        
               moveToResumedLifecycleState(true); 
        
             } 
        
           }

But you can call ReactInstanceManager.builder().setInitialLifecycleState(LifecycleState.BEFORE_CREATE). Then your initial state isn't LifecycleState.RESUMED and will not reach moveToResumedLifecycleState until mReactInstanceManager.onHostResume(this, this); is called.

So maybe you can improve code by:

+ if (mInitialLifecycleState == LifecycleState.RESUMED) {
    Assertions.assertNotNull(
         mCurrentActivity,
-        "activity property has not been set with this builder");
+        "activity needs to be set if initial lifecycle state is resumed");
+ }

hey99xx · 2019-02-14T19:26:18Z

You can see that by default .setInitialLifecycleState(LifecycleState.BEFORE_CREATE) is already called.

So your problem only happens if you called .setInitialLifecycleState(LifecycleState.RESUMED) manually.

react-native/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

Lines 66 to 76 in b002df9

    
           protected ReactInstanceManager createReactInstanceManager() { 
        
             ReactMarker.logMarker(ReactMarkerConstants.BUILD_REACT_INSTANCE_MANAGER_START); 
        
             ReactInstanceManagerBuilder builder = ReactInstanceManager.builder() 
        
               .setApplication(mApplication) 
        
               .setJSMainModulePath(getJSMainModuleName()) 
        
               .setUseDeveloperSupport(getUseDeveloperSupport()) 
        
               .setRedBoxHandler(getRedBoxHandler()) 
        
               .setJavaScriptExecutorFactory(getJavaScriptExecutorFactory()) 
        
               .setUIImplementationProvider(getUIImplementationProvider()) 
        
               .setJSIModulesPackage(getJSIModulePackage()) 
        
               .setInitialLifecycleState(LifecycleState.BEFORE_CREATE);

RoJoHub · 2019-02-15T00:55:00Z

I understand onHostResume is called with null and looks like a bug, but regardless of that you should attempt to fix a bug in a way considering other use cases:

For your flow:

moveReactContextToCurrentLifecycleState ->
moveToResumedLifecycleState(true) ->
currentContext.onHostResume(mCurrentActivity)

moveReactContextToCurrentLifecycleState will call moveToResumedLifecycleState only if it's at LifecycleState.RESUME state:
react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines 693 to 697 in be282b5

private synchronized void moveReactContextToCurrentLifecycleState() {
if (mLifecycleState == LifecycleState.RESUMED) {
moveToResumedLifecycleState(true);
}
}
But you can call ReactInstanceManager.builder().setInitialLifecycleState(LifecycleState.BEFORE_CREATE). Then your initial state isn't LifecycleState.RESUMED and will not reach moveToResumedLifecycleState until mReactInstanceManager.onHostResume(this, this); is called.

So maybe you can improve code by:
+ if (mInitialLifecycleState == LifecycleState.RESUMED) {
    Assertions.assertNotNull(
         mCurrentActivity,
-        "activity property has not been set with this builder");
+        "activity needs to be set if initial lifecycle state is resumed");
+ }

You can see that by default .setInitialLifecycleState(LifecycleState.BEFORE_CREATE) is already called.

So your problem only happens if you called .setInitialLifecycleState(LifecycleState.RESUMED) manually.

react-native/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

Lines 66 to 76 in b002df9

protected ReactInstanceManager createReactInstanceManager() {
ReactMarker.logMarker(ReactMarkerConstants.BUILD_REACT_INSTANCE_MANAGER_START);
ReactInstanceManagerBuilder builder = ReactInstanceManager.builder()
.setApplication(mApplication)
.setJSMainModulePath(getJSMainModuleName())
.setUseDeveloperSupport(getUseDeveloperSupport())
.setRedBoxHandler(getRedBoxHandler())
.setJavaScriptExecutorFactory(getJavaScriptExecutorFactory())
.setUIImplementationProvider(getUIImplementationProvider())
.setJSIModulesPackage(getJSIModulePackage())
.setInitialLifecycleState(LifecycleState.BEFORE_CREATE);

You're right.
But docs is said that integration-with-existing-apps-Android .

public class MyReactActivity extends Activity implements DefaultHardwareBackBtnHandler {
    private ReactRootView mReactRootView;
    private ReactInstanceManager mReactInstanceManager;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        mReactRootView = new ReactRootView(this);
        mReactInstanceManager = ReactInstanceManager.builder()
                .setApplication(getApplication())
                .setBundleAssetName("index.android.bundle")
                .setJSMainModulePath("index")
                .addPackage(new MainReactPackage())
                .setUseDeveloperSupport(BuildConfig.DEBUG)
                .setInitialLifecycleState(LifecycleState.RESUMED)
                .build();
        // The string here (e.g. "MyReactNativeApp") has to match
        // the string in AppRegistry.registerComponent() in index.js
        mReactRootView.startReactApplication(mReactInstanceManager, "MyReactNativeApp", null);

        setContentView(mReactRootView);
    }

    @Override
    public void invokeDefaultOnBackPressed() {
        super.onBackPressed();
    }
}

It's call setInitialLifecycleState(LifecycleState.RESUMED).
So.this bug only happen Integration with Existing Apps-Android

RoJoHub · 2019-02-15T01:01:41Z

@hey99xx

We are asynchronous to set the value of `mCurrentActivity` in `ReactInstanceManager`!!!!!!

Execute first

@Override
protected void onResume() {
    super.onResume();

    if (mReactInstanceManager != null) {
        mReactInstanceManager.onHostResume(this, this);
    }
}

Post execution

@Override
protected void onResume() {
    super.onResume();

    if (mReactInstanceManager != null) {
        mReactInstanceManager.onHostResume(this, this);
    }
}

I have a place before I said something wrong.

moveToResumedLifecycleState(true) is run faster than mReactInstanceManager.onHostResume(this, this);

At this time,the state is LifecycleState.RESUMED,and also the value of mCurrentActivityis null.

So it caused this bug.#13439

RoJoHub · 2019-02-15T02:27:22Z

@hey99xx
I have change my pr.
Please review my code again.

Also we should change doc of android.
integration-with-existing-apps-android

public class MyReactActivity extends Activity implements DefaultHardwareBackBtnHandler {
    private ReactRootView mReactRootView;
    private ReactInstanceManager mReactInstanceManager;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        mReactRootView = new ReactRootView(this);
        mReactInstanceManager = ReactInstanceManager.builder()
                .setApplication(getApplication())
+               .setCurrentActivity(this)
                .setBundleAssetName("index.android.bundle")
                .setJSMainModulePath("index")
                .addPackage(new MainReactPackage())
                .setUseDeveloperSupport(BuildConfig.DEBUG)
                .setInitialLifecycleState(LifecycleState.RESUMED)
                .build();
        // The string here (e.g. "MyReactNativeApp") has to match
        // the string in AppRegistry.registerComponent() in index.js
        mReactRootView.startReactApplication(mReactInstanceManager, "MyReactNativeApp", null);

        setContentView(mReactRootView);
    }

    @Override
    public void invokeDefaultOnBackPressed() {
        super.onBackPressed();
    }
}

hey99xx · 2019-02-15T02:35:09Z

I'll approve the PR but I'm neither working for FB nor a maintainer for react-native so you'll wait for someone else's approval.

Also we should change doc of android.

Agreed. Do you want to send a pull request to https://github.com/facebook/react-native-website/blob/master/docs/integration-with-existing-apps.md too?

RoJoHub · 2019-02-15T02:38:47Z

I'll approve the PR but I'm neither working for FB nor a maintainer for react-native so you'll wait for someone else's approval.

Also we should change doc of android.

Agreed. Do you want to send a pull request to https://github.com/facebook/react-native-website/blob/master/docs/integration-with-existing-apps.md too?

Haha, I just submitted this PR#792.
Please help me see it. Thank you!!!

RoJoHub · 2019-02-23T05:07:58Z

@mdvacca
I update Summary and ChangeLog
Please review again.

cpojer

This looks good.

cpojer · 2019-03-05T09:00:45Z

It seems like the only thing in our way is one more internal test that is now failing. I'm unfortunately not an Android expert so I'm unsure how to get the current activity so I can set it on the builder. All I seem to have available is an InstrumentationRegistry (from android.support.test.InstrumentationRegistry) or an InstrumentationTestCase (from android.test.InstrumentationTestCase). Do you have any idea about how I could patch up my test?

It does seem that part of the test is to wait for a ReactContext to be initialized asynchronously, so I'm unsure whether this can be fixed :O

RoJoHub · 2019-03-05T11:25:36Z

InstrumentationTestCase

Maybe is that? @cpojer

    Activity activity = (Activity)InstrumentationRegistry.getTargetContext();
    build.setCurrentActivity(activity);

Related to Get context of test project in Android junit test case

facebook-github-bot · 2019-03-08T21:49:28Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

RoJoHub · 2019-03-10T03:59:36Z

I can't find other info for this pr because The current problem is that this test is internal .

Could you please tell what to do next?

cpojer · 2019-03-13T02:49:47Z

@RoJoHub sorry I was away last week so I couldn't get to this. I just tried your proposed change but now it causes an issue when destroying the instance manager: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.ReactInstanceManager.destroy()' on a null object reference :(

RoJoHub · 2019-03-13T04:06:51Z

@RoJoHub sorry I was away last week so I couldn't get to this. I just tried your proposed change but now it causes an issue when destroying the instance manager: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.ReactInstanceManager.destroy()' on a null object reference :(

Now the error prompts that the onDestory method is called on a null object.

The current information can't make me locate the error.

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.ReactInstanceManager.destroy()' on a null object reference

By the way ,It's hard to locate where the error is.
Beacause I don't know what happened to the internal test.

cpojer · 2019-03-13T04:45:14Z

I'm sorry for making this hard but I'm not an expert on this part of the codebase so it's a bit hard. I did the cast as you suggested but maybe it didn't work properly and it is now setting the wrong thing as the activity, that then later crashes? Do you have any suggestions on how I could figure this out properly?

Merge

RoJoHub · 2019-03-14T17:09:38Z

@cpojer
I don't know which class is used for internal testing.But I have three ways to solve.

Case 1: ActivityInstrumentationTestCase2

If We extend ActivityInstrumentationTestCase2.The generics is class of activity.
For example :extends ActivityInstrumentationTestCase2<ReactAppTestActivity>

react-native/ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactInstrumentationTest.java

Lines 26 to 49 in b41ce43

    
           public abstract class ReactInstrumentationTest 
        
               extends ActivityInstrumentationTestCase2<ReactAppTestActivity> implements IdleWaiter { 
        
             protected StringRecordingModule mRecordingModule; 
        
             @Nullable protected FabricUIManagerFactory mFabricUIManagerFactory = null; 
        
             @Nullable protected JavaScriptExecutorFactory mJavaScriptExecutorFactory = null; 
        
             public ReactInstrumentationTest() { 
        
               super(ReactAppTestActivity.class); 
        
             } 
        
             @Override 
        
             protected void setUp() throws Exception { 
        
               super.setUp(); 
        
               Intent intent = new Intent(); 
        
               intent.putExtra(ReactAppTestActivity.EXTRA_IS_FABRIC_TEST, isFabricTest()); 
        
               setActivityIntent(intent); 
        
               mRecordingModule = new StringRecordingModule(); 
        
               final ReactAppTestActivity activity = getActivity(); 
        
               activity.loadBundle(createReactInstanceSpecForTest(), getBundleName(), getEnableDevSupport()); 
        
             }

If we want get activity,just call getActivity()

Activity activity = getActivity();

Case 2: AndroidJUnit4.class

If an annotation is AndroidJUnit4.class.

we should set a activity that we want to test.

@Rule public ActivityTestRule<Activity> mActivityRule = new ActivityTestRule<>(Activity.class);

If we want get activity,just call mActivityRule.getActivity()

Activity activity = mActivityRule.getActivity();

react-native/ReactAndroid/src/androidTest/java/com/facebook/react/tests/core/ReactInstanceManagerTest.java

Lines 25 to 37 in be282b5

    
           public class ReactInstanceManagerTest { 
        
             private static final String TEST_MODULE = "ViewLayoutTestApp"; 
        
             private ReactInstanceManager mReactInstanceManager; 
        
             private ReactRootView mReactRootView; 
        
             @Rule public ActivityTestRule<Activity> mActivityRule = new ActivityTestRule<>(Activity.class); 
        
             @Before 
        
             public void setup() { 
        
               Activity activity = mActivityRule.getActivity(); 
        
               mReactRootView = new ReactRootView(activity);

Case 3: InstrumentationTestCase & InstrumentationRegistry

It's from [developer.android.com->startActivitySync]
public Activity startActivitySync (Intent intent)

(https://developer.android.com/reference/android/app/Instrumentation.html#startActivitySync(android.content.Intent))

        Instrumentation instrumentation = InstrumentationRegistry.getInstrumentation();
        Intent intent = new Intent();
        intent.setClass(instrumentation.getTargetContext(), Activity.class);
        Activity activity =InstrumentationRegistry.getInstrumentation().startActivitySync(intent);

Finally,we get activity.

RoJoHub · 2019-03-23T15:23:20Z

@cpojer

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cpojer · 2019-06-12T12:12:08Z

Thanks to @makovkastar who fixed the internal issue we were having I was finally able to land this Pull Request. I want to apologize again for how long it took.

react-native-bot · 2019-06-12T12:15:05Z

This pull request was successfully merged by @RoJoHub in fb550e9.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: Issues: Related to #13439 react-native-website:Related to PR [#792](facebook/react-native-website#792) solution: #13439 (comment) When we integration with Existing Android Apps.and set LifecycleState is `LifecycleState.RESUMED`. It's lead to `mCurrentActivity` is null . At this time , the behave of set `mCurrentActivity ` which is unexpectedly. ## Changelog [Android] [Fixed] - Check if mCurrentActivity is set according to LifecycleState Pull Request resolved: #23336 Differential Revision: D14298654 Pulled By: cpojer fbshipit-source-id: 5cc17539a51154faeb838349b068d92511946f79

…k#23336) Summary: Issues: Related to facebook#13439 react-native-website:Related to PR [facebook#792](facebook/react-native-website#792) solution: facebook#13439 (comment) When we integration with Existing Android Apps.and set LifecycleState is `LifecycleState.RESUMED`. It's lead to `mCurrentActivity` is null . At this time , the behave of set `mCurrentActivity ` which is unexpectedly. ## Changelog [Android] [Fixed] - Check if mCurrentActivity is set according to LifecycleState Pull Request resolved: facebook#23336 Differential Revision: D14298654 Pulled By: cpojer fbshipit-source-id: 5cc17539a51154faeb838349b068d92511946f79

Merge pull request #2 from facebook/master

f0d20d6

Merge

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2019

matthargett approved these changes Feb 7, 2019

View reviewed changes

react-native-bot added Platform: Android Android applications. PR: Includes Changelog labels Feb 7, 2019

cpojer requested a review from mdvacca February 8, 2019 09:08

inspect_mCurrentActivity

0cc7932

RoJoHub force-pushed the jerry_fix_#13439 branch from 881f8e8 to 0cc7932 Compare February 15, 2019 02:25

hey99xx approved these changes Feb 15, 2019

View reviewed changes

RoJoHub mentioned this pull request Feb 15, 2019

fix_#23336 facebook/react-native-website#792

Merged

RoJoHub changed the title ~~[Android] Sometimes setupReactContextRunnable is run faster than maybeRecreateR…~~ [Android] Added check of the status of the activity Feb 23, 2019

RoJoHub changed the title ~~[Android] Added check of the status of the activity~~ [Android] Check if mCurrentActivity is set according to LifecycleState Feb 23, 2019

cpojer approved these changes Mar 4, 2019

View reviewed changes

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Mar 4, 2019

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Mar 5, 2019

hramos removed the Import Failed label Mar 8, 2019

facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Mar 8, 2019

RoJoHub and others added 2 commits March 13, 2019 13:33

Merge pull request #4 from facebook/master

6dd226d

Merge

Merge branch 'master' into jerry_fix_#13439

239a472

react-native-bot added PR: Includes Changelog labels Mar 14, 2019

hramos removed the PR: Includes Changelog label Mar 14, 2019

react-native-bot added the Bug label May 3, 2019

hramos removed Type: Bug Fix🐛 labels May 6, 2019

facebook-github-bot approved these changes Jun 10, 2019

View reviewed changes

facebook-github-bot closed this in fb550e9 Jun 12, 2019

react-native-bot added Merged This PR has been merged. and removed Import Failed labels Jun 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Check if mCurrentActivity is set according to LifecycleState #23336

[Android] Check if mCurrentActivity is set according to LifecycleState #23336

RoJoHub commented Feb 7, 2019 •

edited

Loading

RoJoHub commented Feb 7, 2019 •

edited

Loading

matthargett left a comment

RoJoHub commented Feb 7, 2019

RoJoHub commented Feb 7, 2019 •

edited

Loading

hey99xx commented Feb 14, 2019

hey99xx commented Feb 14, 2019

RoJoHub commented Feb 14, 2019 •

edited

Loading

RoJoHub commented Feb 14, 2019 •

edited

Loading

RoJoHub commented Feb 14, 2019 •

edited

Loading

hey99xx commented Feb 14, 2019 •

edited

Loading

hey99xx commented Feb 14, 2019

RoJoHub commented Feb 15, 2019 •

edited

Loading

RoJoHub commented Feb 15, 2019

We are asynchronous to set the value of `mCurrentActivity` in `ReactInstanceManager`!!!!!!

Execute first

Post execution

RoJoHub commented Feb 15, 2019

hey99xx commented Feb 15, 2019

RoJoHub commented Feb 15, 2019 •

edited

Loading

RoJoHub commented Feb 23, 2019

cpojer left a comment

cpojer commented Mar 5, 2019

RoJoHub commented Mar 5, 2019 •

edited

Loading

facebook-github-bot commented Mar 8, 2019

RoJoHub commented Mar 10, 2019

cpojer commented Mar 13, 2019

RoJoHub commented Mar 13, 2019

cpojer commented Mar 13, 2019

RoJoHub commented Mar 14, 2019 •

edited

Loading

RoJoHub commented Mar 23, 2019

facebook-github-bot left a comment

cpojer commented Jun 12, 2019

react-native-bot commented Jun 12, 2019

[Android] Check if mCurrentActivity is set according to LifecycleState #23336

[Android] Check if mCurrentActivity is set according to LifecycleState #23336

Conversation

RoJoHub commented Feb 7, 2019 • edited Loading

Summary

Changelog

Test Plan

RoJoHub commented Feb 7, 2019 • edited Loading

matthargett left a comment

Choose a reason for hiding this comment

RoJoHub commented Feb 7, 2019

RoJoHub commented Feb 7, 2019 • edited Loading

hey99xx commented Feb 14, 2019

hey99xx commented Feb 14, 2019

RoJoHub commented Feb 14, 2019 • edited Loading

Please observe its running order

Summary

RoJoHub commented Feb 14, 2019 • edited Loading

We are asynchronous to set the value of mCurrentActivity in ReactInstanceManager!!!!!!

Execute first

Post execution

RoJoHub commented Feb 14, 2019 • edited Loading

Two point to set mCurrentActivity

hey99xx commented Feb 14, 2019 • edited Loading

hey99xx commented Feb 14, 2019

RoJoHub commented Feb 15, 2019 • edited Loading

RoJoHub commented Feb 15, 2019

We are asynchronous to set the value of mCurrentActivity in ReactInstanceManager!!!!!!

Execute first

Post execution

RoJoHub commented Feb 15, 2019

hey99xx commented Feb 15, 2019

RoJoHub commented Feb 15, 2019 • edited Loading

RoJoHub commented Feb 23, 2019

cpojer left a comment

Choose a reason for hiding this comment

cpojer commented Mar 5, 2019

RoJoHub commented Mar 5, 2019 • edited Loading

facebook-github-bot commented Mar 8, 2019

RoJoHub commented Mar 10, 2019

cpojer commented Mar 13, 2019

RoJoHub commented Mar 13, 2019

cpojer commented Mar 13, 2019

RoJoHub commented Mar 14, 2019 • edited Loading

Case 1: ActivityInstrumentationTestCase2

Case 2: AndroidJUnit4.class

Case 3: InstrumentationTestCase & InstrumentationRegistry

RoJoHub commented Mar 23, 2019

facebook-github-bot left a comment

Choose a reason for hiding this comment

cpojer commented Jun 12, 2019

react-native-bot commented Jun 12, 2019

RoJoHub commented Feb 7, 2019 •

edited

Loading

RoJoHub commented Feb 7, 2019 •

edited

Loading

RoJoHub commented Feb 7, 2019 •

edited

Loading

RoJoHub commented Feb 14, 2019 •

edited

Loading

RoJoHub commented Feb 14, 2019 •

edited

Loading

We are asynchronous to set the value of `mCurrentActivity` in `ReactInstanceManager`!!!!!!

RoJoHub commented Feb 14, 2019 •

edited

Loading

Two point to set `mCurrentActivity`

hey99xx commented Feb 14, 2019 •

edited

Loading

RoJoHub commented Feb 15, 2019 •

edited

Loading

We are asynchronous to set the value of `mCurrentActivity` in `ReactInstanceManager`!!!!!!

RoJoHub commented Feb 15, 2019 •

edited

Loading

RoJoHub commented Mar 5, 2019 •

edited

Loading

RoJoHub commented Mar 14, 2019 •

edited

Loading