Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] helpful error on canOpenURL for missing scheme #23535

Closed
wants to merge 2 commits into from
Closed

[iOS] helpful error on canOpenURL for missing scheme #23535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5c49fd
check if scheme exists in LSApplicationQueriesSchemes for canOpenURL
ericlewis Feb 19, 2019
51944ca
Update RCTLinkingManager.m
cpojer Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 15 additions & 5 deletions Libraries/LinkingIOS/RCTLinkingManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,23 @@ - (void)handleOpenURLNotification:(NSNotification *)notification
return;
}

// TODO: on iOS9 this will fail if URL isn't included in the plist
// we should probably check for that and reject in that case instead of
// simply resolving with NO

// This can be expensive, so we deliberately don't call on main thread
BOOL canOpen = [RCTSharedApplication() canOpenURL:URL];
resolve(@(canOpen));

NSString *scheme = [URL scheme];

// On iOS 9 and above canOpenURL returns NO without a helpful error.
// Check if a custom scheme is being used, and if it exists in LSApplicationQueriesSchemes
if (![[scheme lowercaseString] hasPrefix:@"http"] && ![[scheme lowercaseString] hasPrefix:@"https"]) {
NSArray *querySchemes = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"LSApplicationQueriesSchemes"];
if (querySchemes != nil && ([querySchemes containsObject:scheme] || [querySchemes containsObject:[scheme lowercaseString]])) {
resolve(@(canOpen));
} else {
reject(RCTErrorUnspecified, [NSString stringWithFormat:@"Unable to open URL: %@. Add %@ to LSApplicationQueriesSchemes in your Info.plist.", URL, scheme], nil);
}
} else {
resolve(@(canOpen));
}
}

RCT_EXPORT_METHOD(getInitialURL:(RCTPromiseResolveBlock)resolve
Expand Down