Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS e2e test #23566

Closed
wants to merge 2 commits into from
Closed

Fix iOS e2e test #23566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b828015
e2e test working again for iOS.
ericlewis Feb 21, 2019
1beaf98
update target os
ericlewis Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,10 @@ aliases:
name: iOS Test Suite
command: ./scripts/objc-test-ios.sh test

- &run-objc-ios-e2e-tests
name: iOS End-to-End Test Suite
command: node ./scripts/run-ci-e2e-tests.js --ios --retries 3;

- &display-broken-tests-warning
name: Running broken tests (Ignore any failures past this point)
command: |
Expand All @@ -255,9 +259,6 @@ aliases:
- &run-e2e-tests
name: End-to-End Test Suite
command: ./scripts/run-ci-e2e-tests.js --android --ios --js --retries 3;
- &run-objc-ios-e2e-tests
name: iOS End-to-End Test Suite
command: node ./scripts/run-ci-e2e-tests.js --ios --retries 3;
- &run-android-e2e-tests
name: Android End-to-End Test Suite
command: node ./scripts/run-ci-e2e-tests.js --android --retries 3;
Expand Down Expand Up @@ -367,6 +368,7 @@ jobs:
- restore-cache: *restore-cache-homebrew
- run: *brew-install-watchman
- save-cache: *save-cache-homebrew
- run: *run-objc-ios-e2e-tests
- run: *run-objc-ios-tests

- store_test_results:
Expand Down
12 changes: 2 additions & 10 deletions scripts/run-ci-e2e-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,7 @@ let exitCode;

try {
// install CLI
cd('react-native-cli');
exec('yarn pack');
const CLI_PACKAGE = path.join(
ROOT,
'react-native-cli',
'react-native-cli-*.tgz',
);
cd('..');

const CLI_PACKAGE = 'react-native-cli';
if (!argv['skip-cli-install']) {
if (exec(`sudo yarn global add ${CLI_PACKAGE}`).code) {
echo('Could not install react-native-cli globally.');
Expand Down Expand Up @@ -197,7 +189,7 @@ try {
if (
tryExecNTimes(() => {
exec('sleep 10s');
let destination = 'platform=iOS Simulator,name=iPhone 5s,OS=11.4';
let destination = 'platform=iOS Simulator,name=iPhone 5s,OS=12.1';
let sdk = 'iphonesimulator';
let scheme = 'EndToEndTest';

Expand Down