Fix behaviour of Header, Footer and Empty List components in VirtualizedList when it's inverted #24167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
michalchudziak
changed the title
michalchudziak
changed the title
facebook-github-bot
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @michalchudziak in c13f5d4. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Mar 29, 2019
…zedList when it's inverted (#24167) Summary: Fixes #23453 Fixes #21196 Basically, changes made in #21496 currently breaks behavior of `<VirtualizedList />` and any components that are based on it (`<SectionList />, <FlatList />`). This PR solves both issues listed above. Visual confirmation of the resolved issue: **Vertical, not inverted, not empty**  **Vertical, not inverted, empty**  **Vertical, inverted, not empty**  **Vertical, inverted, empty**  **Horizontal, not inverted, not empty**  **Horizontal, not inverted, empty**  **Horizontal, inverted, not empty**  **Horizontal, inverted, empty**  [General] [Fixed] - Fixed VirtualizedList, SectionList and FlatList behavior on rendering list headers with inverted prop and zero items Pull Request resolved: #24167 Differential Revision: D14642345 Pulled By: cpojer fbshipit-source-id: b530bbbd57f60e53a976ac5db272ea4b2d2b3e99
|
This change made it impossible to do <FlatList
...
{...{ListEmptyComponent}}
contentContainerStyle={{flexGrow: 1}}
/>
function ListEmptyComponent() {
return (
<View style={[{flex: 1, ...]} />
)
}0.59.2 0.59.3 |
|
It's reversed again since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23453
Fixes #21196
Basically, changes made in #21496 currently breaks behavior of
<VirtualizedList />and any components that are based on it (<SectionList />, <FlatList />). This PR solves both issues listed above.Visual confirmation of the resolved issue:
Vertical, not inverted, not empty
Vertical, not inverted, empty
Vertical, inverted, not empty
Vertical, inverted, empty
Horizontal, not inverted, not empty
Horizontal, not inverted, empty
Horizontal, inverted, not empty
Horizontal, inverted, empty
Changelog
[General] [Fixed] - Fixed VirtualizedList, SectionList and FlatList behavior on rendering list headers with inverted prop and zero items
Test Plan
Start
RNTesterapp on ios and android and manipulate the switches to recreate all the scenarios described above.