Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the same JavaScript test script in Sandcastle and Circle #24422

Closed
wants to merge 1 commit into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Apr 11, 2019

Differential Revision: D14895773

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 11, 2019
hramos added a commit to hramos/react-native that referenced this pull request Apr 11, 2019
Summary: Pull Request resolved: facebook#24422

Differential Revision: D14895773

fbshipit-source-id: f89c4b604a615ecb9f21a7f03fbbf90bc2a43833
…k#24422)

Summary:
Consolidate JavaScript tests from open source into a single script that can be executed by both Circle CI and Sandcastle, the internal Facebook CI.

Pull Request resolved: facebook#24422

Differential Revision: D14895773

fbshipit-source-id: fa3efbb569783d972f96cf275e3b0eb63a453b20
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @hramos in 5bac2b7.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 12, 2019
dsyang pushed a commit to dsyang/react-native that referenced this pull request Apr 12, 2019
…k#24422)

Summary:
Consolidate JavaScript tests from open source into a single script that can be executed by both Circle CI and Sandcastle, the internal Facebook CI.

[General] [Changed] - Switch internal and external CI to use the same script when running JavaScript tests

Pull Request resolved: facebook#24422

Reviewed By: cpojer

Differential Revision: D14895773

fbshipit-source-id: d428929cc4e5219e02f5920259e08e0b3d24874c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants