Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactAndroid: JS errors during bundle load were reported as UnknownCppException #24648

Closed
wants to merge 1 commit into from
Closed

ReactAndroid: JS errors during bundle load were reported as UnknownCppException #24648

wants to merge 1 commit into from

Commits on Apr 29, 2019

  1. ReactAndroid: add -fexceptions -frtti to jni CFLAGS 

    This fixes a regression on Android introduced by f3e5cce where JS errors
thrown during bundle load were lost (shown only as UnknownCppException).
It is especially tough to debug (custom) bundling errors without seeing
the javascript error.

Root cause hypothesis: since switching to clang, JSErrors thrown in
ReactCommon's JSCRuntime::checkException were never matched as
std::exception in Android's convertCppExceptionToJavaException due
to these missing flags.
    @EmielM
    EmielM committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    fede301 View commit details
    Browse the repository at this point in the history