[General] fixes fetch module credentials #24726
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #14063, we decided to set
withCredential
totrue
by default, now if we useXMLHttpRequest
, it works, but for fetch polyfill,withCredential
is be set tofalse
because we useRequest
's credentials https://github.com/facebook/react-native/blob/master/Libraries/vendor/core/whatwg-fetch.js#L515.So we have inconsistency about
withCrendential
. My fix is to changeRequest
credentials
default value tosame-origin
, it reasonable because refer to MDN, the default value issame-origin
.cc. @cpojer.
Changelog
[General] [Fixed] - fixes fetch module credentials
Test Plan
For any request from either XMLHttpRequest or fetch, we set
withCredential
to true by default.