Fix Xcode 11 build #25146

ericlewis · 2019-06-04T15:52:36Z

Summary

Fixes build in Xcode 11 beta, the signature for __unused was changed. This adds a new check for the new style.

Changelog

[iOS] [Fixed] - Xcode 11 beta build

Test Plan

Build & run RNTester

ericlewis · 2019-06-04T16:49:07Z

Failing tests seem unrelated.

ericlewis · 2019-06-04T16:55:25Z

props to @zhongwuzw for the debug assist!

eliperkins

Nice one! 🍏

cpojer

🆒

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

react-native-bot · 2019-06-04T20:05:04Z

This pull request was successfully merged by @ericlewis in 46c7ada.

^{When will my fix make it into a release? | Upcoming Releases}

zhongwuzw · 2019-06-05T00:50:54Z

@ericlewis 💯 NSArray related crash is also resolved?

RenderCoder · 2019-06-05T02:03:43Z

Thank you!

ericlewis · 2019-06-05T03:13:14Z

@zhongwuzw yeah! The crash was happening because I left some bad debug code behind 😜

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: #25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7 # Conflicts: # React/Base/RCTModuleMethod.mm

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: #25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

toddrimes · 2019-06-16T18:52:56Z

Hello - how can I install the pre-release package that has this fix?

I'm trying

react-native init RN060 --version react-native@next

but it just keeps installing v0.57.1

Thank you,
~Todd

ericlewis · 2019-06-17T12:47:17Z

This fix is in 0.59.9. Sent via Superhuman iOS ( https://sprh.mn/?vip=ericlewis777@gmail.com )

…

On Sun, Jun 16 2019 at 2:53 PM, < ***@***.*** > wrote: Hello - how can I install the pre-release package that has this fix? I'm trying react-native init RN060 --version ***@***.*** but it just keeps installing v0.57.1 Thank you, ~Todd — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( #25146?email_source=notifications&email_token=AAFEVR3DBWGBBLZB5GUJCALP22DZNA5CNFSM4HS6BRGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZS6VY#issuecomment-502476631 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAFEVR23MLJX47MC35RZUWTP22DZNANCNFSM4HS6BRGA ).

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook/react-native#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7 # Conflicts: # React/Base/RCTModuleMethod.mm

russelRajitha · 2019-09-29T23:39:23Z

same as @luisfusim I am too having this issue ... I am on 0.57.0 and don't want to upgrade the RN version ... So what steps I should take to resolve this ...
Xcode version = 11.0

in your project directory, open file in myproject/node_modules/react-native/React/Base/RCTModuleMethod.mm. Then correct as below: here

working perfectly. you saved my day.

ancyrweb · 2019-10-01T05:34:35Z

@tuanduc2904 that will only work until you clean your node_modules. Other ideas ?

You can use patch-package to perform the update every time you install packages / update them.

tuanduc2904 · 2019-10-01T06:14:29Z

@tuanduc2904 that will only work until you clean your node_modules. Other ideas ?

You can use patch-package to perform the update every time you install packages / update them.

I can't, do you have a solution?

ancyrweb · 2019-10-01T06:19:31Z

Well, I just tried, looks like the diff is too heavy for github.

tuanduc2904 · 2019-10-01T06:25:23Z

I had to revise it many times when adding new packages to my project

eyupcimen · 2019-10-03T04:52:35Z

same as @luisfusim I am too having this issue ... I am on 0.57.0 and don't want to upgrade the RN version ... So what steps I should take to resolve this ...
Xcode version = 11.0

in your project directory, open file in myproject/node_modules/react-native/React/Base/RCTModuleMethod.mm. Then correct as below: here

This working. Thank you

- react native 0.59.9 introduces a fix for a bug stopping builds with xcode 11: facebook/react-native#25146 - also the recent name update needed a change to a file in the ios/ dir - finding and fixing these issues was a *major pain*

GleidsonDaniel · 2019-10-11T16:30:32Z

Tks @tuanduc2904 , saved my time!

RN version 0.59.10, worked like a charm!

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7 Commit: 46c7ada [46c7ada] Author: Eric Lewis <ericlewis777@gmail.com> Date: 4 June 2019 at 20:54:59 BST Commit Date: 4 June 2019 at 20:59:34 BST

facebook@46c7ada

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7 (cherry picked from commit 46c7ada)

29er · 2019-10-24T21:23:24Z

why is this closed? I still get the error.
do I really have to go modify RCTModuleMethod every time I install ????

Unknown argument type 'attribute' in method -[EXAppState getCurrentAppState:error:]. Extend RCTConvert to support this type.

"react": "16.8.3",
"react-native": "https://github.com/expo/react-native/archive/sdk-34.0.0.tar.gz",

Rambatino · 2019-10-24T21:27:04Z

Just upgrade react-native package @29er

29er · 2019-10-24T21:34:05Z

ok thanks @Rambatino ! . I will try 35.0

- Required to backport #24155 (previous commit) - facebook/react-native#25146 - Occurred during upgrade: xcode 10 -> 11 - Safe to XXX after react-native 0.59.10 (currently 0.57.2)

kailash1805a · 2019-11-02T03:15:30Z

It's working
https://github.com/facebook/react-native/pull/25146/files#diff-263fc157dfce55895cdc16495b55d190

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook/react-native#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

react native 0.59 has a red screen issue for xcode11, regenate the container for react native 0.60: facebook/react-native#25146

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

- Required to backport #24155 (previous commit) - facebook/react-native#25146 - Occurred during upgrade: xcode 10 -> 11 - Safe to XXX after react-native 0.59.10 (currently 0.57.2)

lucky-vishwakarma · 2020-02-19T09:38:06Z

I also have same issue but these solution does not work for me. I am using
xcode 11.3
React native 57.8

Summary: Fixes build in Xcode 11 beta, the signature for `__unused` was changed. This adds a new check for the new style. ## Changelog [iOS] [Fixed] - Xcode 11 beta build Pull Request resolved: facebook#25146 Differential Revision: D15628404 Pulled By: cpojer fbshipit-source-id: 781a188a0e1562a3316fbe62920b12b03a44e4a7

jayasme · 2020-04-09T05:00:39Z

Upgrade to RN 0.59.9 or above in your package.json
rm -rf node_modules/
yarn
pod install
Clean in Xcode
yarn start --reset-cache
Build in Xcode

AshishKapoor · 2020-09-09T19:56:01Z

React/Base/RCTModuleMethod.mm

@@ -91,6 +91,7 @@ static BOOL RCTParseSelectorPart(const char **input, NSMutableString *selector)
 static BOOL RCTParseUnused(const char **input)
 {
  return RCTReadString(input, "__attribute__((unused))") ||
+         RCTReadString(input, "__attribute__((__unused__))") ||


Hi, may I know which file this is please? Thanks very much!

aasif1297

not working

Fix unused method signature

61b8b9e

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jun 4, 2019

react-native-bot added Bug Platform: iOS iOS applications. labels Jun 4, 2019

ericlewis marked this pull request as ready for review June 4, 2019 16:12

ericlewis requested a review from shergin as a code owner June 4, 2019 16:12

ericlewis mentioned this pull request Jun 4, 2019

iOS build fails to run in with Xcode 11.0 beta #25138

Closed

ericlewis requested a review from zhongwuzw June 4, 2019 16:49

eliperkins approved these changes Jun 4, 2019

View reviewed changes

cpojer approved these changes Jun 4, 2019

View reviewed changes

facebook-github-bot approved these changes Jun 4, 2019

View reviewed changes

cpojer mentioned this pull request Jun 4, 2019

Fix unused attribute parsing for Xcode 11 beta #25148

Closed

facebook-github-bot closed this in 46c7ada Jun 4, 2019

react-native-bot added the Merged This PR has been merged. label Jun 4, 2019

dyy1993 pushed a commit to dyy1993/react-native that referenced this pull request Aug 28, 2019

fix:ios 13 crash facebook#25146

cdb5fdf

remigarcia mentioned this pull request Oct 7, 2019

Splash screen not working on iOS13/RN 0.60 crazycodeboy/react-native-splash-screen#402

Open

ksti added a commit to sinooceanland/react-native that referenced this pull request Oct 22, 2019

Fix Xcode 11 build (facebook#25146)

dae69c4

facebook@46c7ada

liulianci added a commit to liulianci/ernnavigation-api-impl-native that referenced this pull request Dec 10, 2019

update iOS container

93ccf5a

react native 0.59 has a red screen issue for xcode11, regenate the container for react native 0.60: facebook/react-native#25146

liulianci mentioned this pull request Dec 10, 2019

update iOS container electrode-io/ernnavigation-api-impl-native#59

Closed

AshishKapoor reviewed Sep 9, 2020

View reviewed changes

aasif1297 reviewed Aug 22, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Xcode 11 build #25146

Fix Xcode 11 build #25146

ericlewis commented Jun 4, 2019 •

edited

ericlewis commented Jun 4, 2019

ericlewis commented Jun 4, 2019

eliperkins left a comment

cpojer left a comment

facebook-github-bot left a comment

react-native-bot commented Jun 4, 2019

zhongwuzw commented Jun 5, 2019

RenderCoder commented Jun 5, 2019

ericlewis commented Jun 5, 2019

toddrimes commented Jun 16, 2019

ericlewis commented Jun 17, 2019 via email

russelRajitha commented Sep 29, 2019

ancyrweb commented Oct 1, 2019

tuanduc2904 commented Oct 1, 2019

ancyrweb commented Oct 1, 2019

tuanduc2904 commented Oct 1, 2019

eyupcimen commented Oct 3, 2019

GleidsonDaniel commented Oct 11, 2019

29er commented Oct 24, 2019 •

edited

Rambatino commented Oct 24, 2019

29er commented Oct 24, 2019

kailash1805a commented Nov 2, 2019

lucky-vishwakarma commented Feb 19, 2020

jayasme commented Apr 9, 2020

AshishKapoor Sep 9, 2020

NamelessLee Dec 3, 2021

aasif1297 left a comment

Fix Xcode 11 build #25146

Fix Xcode 11 build #25146

Conversation

ericlewis commented Jun 4, 2019 • edited

Summary

Changelog

Test Plan

ericlewis commented Jun 4, 2019

ericlewis commented Jun 4, 2019

eliperkins left a comment

Choose a reason for hiding this comment

cpojer left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

react-native-bot commented Jun 4, 2019

zhongwuzw commented Jun 5, 2019

RenderCoder commented Jun 5, 2019

ericlewis commented Jun 5, 2019

toddrimes commented Jun 16, 2019

ericlewis commented Jun 17, 2019 via email

russelRajitha commented Sep 29, 2019

ancyrweb commented Oct 1, 2019

tuanduc2904 commented Oct 1, 2019

ancyrweb commented Oct 1, 2019

tuanduc2904 commented Oct 1, 2019

eyupcimen commented Oct 3, 2019

GleidsonDaniel commented Oct 11, 2019

29er commented Oct 24, 2019 • edited

Rambatino commented Oct 24, 2019

29er commented Oct 24, 2019

kailash1805a commented Nov 2, 2019

lucky-vishwakarma commented Feb 19, 2020

jayasme commented Apr 9, 2020

AshishKapoor Sep 9, 2020

Choose a reason for hiding this comment

NamelessLee Dec 3, 2021

Choose a reason for hiding this comment

aasif1297 left a comment

Choose a reason for hiding this comment

ericlewis commented Jun 4, 2019 •

edited

29er commented Oct 24, 2019 •

edited