Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Animation EndResult callback to return Promise #25793

Closed
wants to merge 2 commits into from
Closed

Allow Animation EndResult callback to return Promise #25793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea74da
Allow Animation EndResult callback to return any
draperunner Jul 23, 2019
28b9639
Use void | Promise<void>, not any, to emphasize meaningless return value
draperunner Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Animated/src/NativeAnimatedModule.js
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ import type {TurboModule} from '../../TurboModule/RCTExport';
import * as TurboModuleRegistry from '../../TurboModule/TurboModuleRegistry';

type EndResult = {finished: boolean};
type EndCallback = (result: EndResult) => void;
type EndCallback = (result: EndResult) => void | Promise<void>;

export type EventMapping = {|
nativeEventPath: Array<string>,
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Animated/src/animations/Animation.js
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ const NativeAnimatedHelper = require('../NativeAnimatedHelper');
import type AnimatedValue from '../nodes/AnimatedValue';

export type EndResult = {finished: boolean};
export type EndCallback = (result: EndResult) => void;
export type EndCallback = (result: EndResult) => void | Promise<void>;

export type AnimationConfig = {
isInteraction?: boolean,
Expand Down