fix: avoid calling Timing.deleteTimer for setImmediate and requestIdleCallback #26113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cpojer
approved these changes
Sep 11, 2019
facebook-github-bot
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @aleclarson in 4fc3e7a. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 23, 2023
Summary: Previously, we'd call and use getSnapshot on the second render resulting in `Warning: Text content did not match. Server: "Nay!" Client: "Yay!"` and then `Error: Text content does not match server-rendered HTML.`. Fixes #26095. Closes #26113. Closes #25650. --------- DiffTrain build for commit facebook/react@4cd7065. Reviewed By: mofeiZ Differential Revision: D45829972 Pulled By: sammy-SC fbshipit-source-id: e89404c53a1b8478d22252ca24ddcc9647744d37 Co-authored-by: eps1lon <silbermann.sebastian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a simple error where
types[index]was being accessed after it was cleared, instead of before.Changelog
[iOS] [Fixed] - never call deleteTimer for setImmediate and requestIdleCallback
Test Plan
None