Revert "Set rounded rectangle mask on TouchableNativeFeedback's rippl… #26682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Ios ci is crying :( |
|
I don't think that would be related to this PR as it's Android only tho. |
|
Unfortunately, this PR hasn't been merged and looks like somebody commited a fix directly to mastr branch few days ago. Well... in this case, I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 14b455f. Fixes #26544. Reopens #6480
Summary
The commit introduced regression #26544. Rolling it back fixes the issue.
Test Plan
Test plan is in the #26544, I have confirmed it to be working. You can render
borderRadiuswithelevationand observe the glitch (on latest Android API).