New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the packager infinite loop on Windows #2789
Conversation
The issue here facebook#2787 The root path '/' dosn't match windows root path
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks for the PR! @martinbigio Can you review this please? |
Looks good to me! |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/830425153722383/int_phab to review. |
@@ -226,7 +226,7 @@ class ResolutionRequest { | |||
realModuleName => { | |||
const searchQueue = []; | |||
for (let currDir = path.dirname(fromModule.path); | |||
currDir !== '/'; | |||
currDir !== path.parse(fromModule.path).root; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result of the path.parse
call is constant and this is being evaluated on each iteration so it makes sense to hoist this.
Thanks @sebmck , that make more sence.
Thanks @sebmck , yet I think the other code on master causing the ci building failed. |
f5409c1
Summary: The issue here facebook#2787 The root path '/' dosn't match windows root path Closes facebook#2789 Reviewed By: @svcscm Differential Revision: D2452718 Pulled By: @martinbigio
Summary: The issue here facebook/react-native#2787 The root path '/' dosn't match windows root path Closes facebook/react-native#2789 Reviewed By: @svcscm Differential Revision: D2452718 Pulled By: @martinbigio
The issue here #2787
The root path '/' dosn't match windows root path