Enable nested scrolling of horizontal scrollviews on Android #28138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On iOS nested scrolling in horizontal ScrollViews work out of box, on Android it's actually limited by Android's HorizontalScrollView implementation. By slight adjustment in ReactHorizontalScrollView we can have feature parity on Android as well.
Changelog
[Android] [Changed] - Enabled scrolling in nested horizontal ScrollViews
Test Plan
Steps to test
App.js
with this gistI would love to write integration and probably some performance test but I'm having problem running them from Android Studio. Only thing I'm able to achieve is to run all test with buck. I would be grateful for any guidance. Also I understand that that lookup code could be performance bottleneck in some extreme cases and I'm willing to optimize it further if it will be considered worthy馃槃