New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected computation of RCText element height with padding #2838

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@quentinadam
Contributor

quentinadam commented Sep 18, 2015

Corrected computation of RCText element height with padding (padding was counted twice).
See also issue #2466.

@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide Sep 18, 2015

Collaborator

This seems right... the text should be laid out after accounting for padding.

cc @nicklockwood @a2

Collaborator

ide commented Sep 18, 2015

This seems right... the text should be laid out after accounting for padding.

cc @nicklockwood @a2

@mkonicek mkonicek added the 🔷iOS label Sep 19, 2015

@quentinadam

This comment has been minimized.

Show comment
Hide comment
@quentinadam

quentinadam Oct 13, 2015

Contributor

Any update on this PR?

Contributor

quentinadam commented Oct 13, 2015

Any update on this PR?

@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide Oct 13, 2015

Collaborator

Can you rebase against master and push again to re-run the latest tests?

Collaborator

ide commented Oct 13, 2015

Can you rebase against master and push again to re-run the latest tests?

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Oct 13, 2015

@quentinadam updated the pull request.

facebook-github-bot commented Oct 13, 2015

@quentinadam updated the pull request.

@nicklockwood

This comment has been minimized.

Show comment
Hide comment
@nicklockwood

nicklockwood Oct 13, 2015

Contributor

Looks good, I just need to check what's going on with that layout error.

@facebook-github-bot shipit

Contributor

nicklockwood commented Oct 13, 2015

Looks good, I just need to check what's going on with that layout error.

@facebook-github-bot shipit

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot commented Oct 13, 2015

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1627647750832567/int_phab to review.

@ghost ghost closed this in c73ceff Oct 13, 2015

MattFoley added a commit to skillz/react-native that referenced this pull request Nov 9, 2015

Corrected computation of RCText element height with padding
Summary: Corrected computation of RCText element height with padding (padding was counted twice).
See also issue #2466.
Closes facebook#2838

Reviewed By: @​svcscm

Differential Revision: D2535924

Pulled By: @nicklockwood

fb-gh-sync-id: b9527803c0a5a6eed1db7e37c98b628750ab2045

Crash-- added a commit to Crash--/react-native that referenced this pull request Dec 24, 2015

Corrected computation of RCText element height with padding
Summary: Corrected computation of RCText element height with padding (padding was counted twice).
See also issue #2466.
Closes facebook#2838

Reviewed By: @​svcscm

Differential Revision: D2535924

Pulled By: @nicklockwood

fb-gh-sync-id: b9527803c0a5a6eed1db7e37c98b628750ab2045

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment