Corrected computation of RCText element height with padding #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
This seems right... the text should be laid out after accounting for padding. cc @nicklockwood @a2 |
|
Any update on this PR? |
|
Can you rebase against master and push again to re-run the latest tests? |
…was counted twice)
|
@quentinadam updated the pull request. |
|
Looks good, I just need to check what's going on with that layout error. @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1627647750832567/int_phab to review. |
ghost
closed this
in
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Nov 9, 2015
Summary: Corrected computation of RCText element height with padding (padding was counted twice). See also issue facebook#2466. Closes facebook#2838 Reviewed By: @svcscm Differential Revision: D2535924 Pulled By: @nicklockwood fb-gh-sync-id: b9527803c0a5a6eed1db7e37c98b628750ab2045
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: Corrected computation of RCText element height with padding (padding was counted twice). See also issue facebook#2466. Closes facebook#2838 Reviewed By: @svcscm Differential Revision: D2535924 Pulled By: @nicklockwood fb-gh-sync-id: b9527803c0a5a6eed1db7e37c98b628750ab2045
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected computation of RCText element height with padding (padding was counted twice).
See also issue #2466.