Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lint config in template #28443

Closed

Conversation

Naturalclar
Copy link
Contributor

Summary

Updating the eslint config and metro-preset used in project template.

Changelog

[General] [Changed] - Upgrade eslint-config and metro-preset in project template

Test Plan

  • Start new project with npx react-native init TestLint
  • upgrade lint and metro-config
  • run lint and start up emulator on iOS and android

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 30, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,596,588 0
android hermes armeabi-v7a 6,273,741 0
android hermes x86 6,936,744 0
android hermes x86_64 6,866,547 0
android jsc arm64-v8a 8,904,972 0
android jsc armeabi-v7a 8,545,447 0
android jsc x86 8,729,149 0
android jsc x86_64 9,305,192 0

Base commit: bbd9144

@analysis-bot
Copy link

analysis-bot commented Mar 30, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 966,896 0

Base commit: bbd9144

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Naturalclar in ad86a18.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 31, 2020
@Naturalclar Naturalclar deleted the chore/updateLintConfig branch April 1, 2020 02:04
sasurau4 pushed a commit to sasurau4/react-native that referenced this pull request Apr 15, 2020
Summary:
Updating the eslint config and metro-preset used in project template.

## Changelog

[General] [Changed] - Upgrade eslint-config and metro-preset in project template
Pull Request resolved: facebook#28443

Test Plan:
- Start new project with `npx react-native init TestLint`
- upgrade lint and metro-config
- run lint and start up emulator on iOS and android

Reviewed By: cpojer

Differential Revision: D20771048

Pulled By: hramos

fbshipit-source-id: a6d387b8687cee348681bcb10d22c7e3de291ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants