Fixed TextInput not being selectable in removeClippedSubviews FlatLists

[hsource]

Summary

Text in TextInputs can't be selected by long press. This happens only when they're inside of FlatLists that are rendered with removeClippedSubview prop set to true on Android.

Fixes #27787

Issue #6085 2 years ago had fixed this issue with a quick fix, but the code has since disappeared in another change. It has a longer explanation for why it's fixed, but essentially - the text is assumed to be not selectable since the TextInput is initialized without being attached to the window. We need to explicitly set the text to be selectable on attachment. This change redoes that change with a 1-line fix.

Changelog

[Android] [Fixed] - Fixed TextInput not being selectable in removeClippedSubviews FlatLists

Test Plan

This can be tested with a new toggle in RNTesterApp.

1. Go to the FlatList in RNTesterApp
2. Toggle on "removeClippedSubviews"
3. Try selecting some text in the list header. It should fail without this comment but succeed with it

Before	After

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,754,447	490
android	hermes	armeabi-v7a	6,419,585	503
android	hermes	x86	7,137,740	502
android	hermes	x86_64	7,027,608	481
android	jsc	arm64-v8a	8,922,265	159
android	jsc	armeabi-v7a	8,579,798	158
android	jsc	x86	8,748,682	175
android	jsc	x86_64	9,324,181	174

Base commit: 16ea9ba

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	809,568	0

Base commit: 16ea9ba

[facebook-github-bot]

@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hsource]

@JoshuaGross - it looks like you've added a bunch of code before for the TextInput on Android - would you be able to give this a quick review? Thanks!

[facebook-github-bot]

@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[JoshuaGross]

@hsource I'm landing this, but had to copy the native code because this needs to be rebased - the JS example files have been moved around, so I couldn't do a clean rebase.

I'm just going to land the native fix for now. If you want to create a separate PR that just adds the examples to RNTester I can approve right away, just ping me.

[JoshuaGross]

@hsource I apologize for the delay in landing this. I'd prefer to give you attribution, but I know you've been waiting for a while and have probably moved on - if you can rebase this and resubmit, I can merge your PR. Otherwise I'll try to recreate and give you attribution manually, but not sure it will work. If I land this myself you could still resubmit just the JS examples to get attribution for that.

[hsource]

Don't worry about attribution! I'm just glad it's getting merged, so we can eventually stop using our own fork of React Native (the only other blocker is #29039, which is related to #29393).

Don't feel like you have to merge the examples either - to be honest, it's probably fine without them - I just used them to test this fix more easily.

[JoshuaGross]

@hsource Thanks for replying. I'll link the merged commit and close this when it's finished.

[react-native-bot]

This pull request was successfully merged by @hsource in 12a50c0.

^{When will my fix make it into a release? | Upcoming Releases}

[JoshuaGross]

@hsource I wasn't sure if it would work, but looks like you got credit anyway. Cheers!