[Android][LogBox] Set windowTranslucentNavigation to false #29399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes facebook#29397. Without this, apps that specify `android:windowTranslucentNavigation` draw the `LogBox` buttons underneath the soft navigation bar, making the buttons unpressable.
facebook-github-bot
added
the
CLA Signed
krizzu
approved these changes
Jul 16, 2020
Base commit: 6ffb983 |
Base commit: 6ffb983 |
satya164
approved these changes
Jul 16, 2020
Ashoat
added a commit
to CommE2E/comm
that referenced
this pull request
Jul 16, 2020
Error messages end up drawing below the navigation bar, which makes the buttons hard to press. My PR facebook/react-native#29399 should fix this. We can revert this commit once we upgrade to a version of React Native that has merged that PR
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mdvacca, I presume something went wrong with the land... is there any way I can help? Failing test cases? |
|
Everything looks good, this is landing now. @Ashoat once this lands, do you want to put a pick request in for 0.63 here: react-native-community/releases#200? |
|
Yeah, will do! |
|
This pull request was successfully merged by @Ashoat in 23036b3. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
Jul 22, 2020
Summary: This fixes #29397. Without this, apps that specify `android:windowTranslucentNavigation` draw the `LogBox` buttons underneath the soft navigation bar, making the buttons unpressable. Before | After :-------------------------:|:-------------------------: <img src="http://ashoat.com/AndroidTranslucentNavigationLogBox.png" width="300" /> | <img src="http://ashoat.com/AndroidTranslucentNavigationLogBoxFixed.png" width="300" /> ## Changelog [Android] [Fixed] - Set LogBox windowTranslucentNavigation to false Pull Request resolved: #29399 Test Plan: I tested this change on the [repo](https://github.com/Ashoat/LogBoxTest) I set up to reproduce the issue. I set it up to [build `ReactAndroid` from source](Ashoat/LogBoxTest@3a2cdab) and then edited `node_modules/react-native/ReactAndroid/src/main/res/devsupport/values/styles.xml` directly. Reviewed By: rickhanlonii Differential Revision: D22602970 Pulled By: mdvacca fbshipit-source-id: 8c2adc149aa0157825075022f00bb695956d3121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #29397. Without this, apps that specify
android:windowTranslucentNavigationdraw theLogBoxbuttons underneath the soft navigation bar, making the buttons unpressable.Changelog
[Android] [Fixed] - Set LogBox windowTranslucentNavigation to false
Test Plan
I tested this change on the repo I set up to reproduce the issue. I set it up to build
ReactAndroidfrom source and then editednode_modules/react-native/ReactAndroid/src/main/res/devsupport/values/styles.xmldirectly.