Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix test_android CI #29509

Closed
wants to merge 1 commit into from
Closed

Attempt to fix test_android CI #29509

wants to merge 1 commit into from

Conversation

jselbo
Copy link

@jselbo jselbo commented Jul 27, 2020 •
edited

Differential Revision: D22780016

Changelog: [Internal]

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 27, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22780016

@pull-bot
Copy link

pull-bot commented Jul 27, 2020 •
edited

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 1052dcd

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a23596f

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22780016

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22780016

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22780016

@jselbo jselbo requested a review from hramos as a code owner July 28, 2020 03:06
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,765,550 156
android hermes armeabi-v7a 6,433,183 145
android hermes x86 7,153,367 139
android hermes x86_64 7,043,287 156
android jsc arm64-v8a 8,936,882 126
android jsc armeabi-v7a 8,596,941 136
android jsc x86 8,767,850 133
android jsc x86_64 9,343,381 133

Base commit: a23596f

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22780016

@facebook-github-bot
Fix test_android CI (#29509)
1052dcd 
Summary: Changelog: [Internal]

Differential Revision: D22780016

fbshipit-source-id: 1acc2d62455b681446a69ae81f3c19a0af5db745
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22780016

facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2020
@facebook-github-bot
Fix test_android CI (#29509)
3094210 
Summary: Changelog: [Internal]

Reviewed By: lunaleaps

Differential Revision: D22780016

fbshipit-source-id: 342465886748d379741e60181aafc68d46a169ee
@jselbo jselbo closed this Jan 20, 2021
@jselbo jselbo deleted the export-D22780016 branch January 20, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jselbo @facebook-github-bot @pull-bot @analysis-bot