[Tests] Move the packager and cli tests to separate matrix entries #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
The packager and cli tests now run independently of the RN JS tests. When the packager moves to its own repo we can just remove the packager entry from .travis.yml. The cli tests are also marked as allowed to fail for now.
ide
force-pushed
the
separate-cli-tests
branch
from
0b19515
to
03c874c
Compare
vjeux
added a commit
that referenced
this pull request
Sep 23, 2015
[Tests] Move the packager and cli tests to separate matrix entries
|
Interesting, let's wait for a few more test runs on Travis to see if the CLI tests are consistently passing now. |
|
From the Jest website: "Runs tests in parallel processes so that they finish sooner". |
|
Queued up 9 more tests: https://travis-ci.org/facebook/react-native/pull_requests. Jest limits itself to the number of cores: https://github.com/facebook/jest/blob/b95c57797673181389bfb5badb8cc26c5fb372fa/src/TestRunner.js#L39. I am not sure but the Travis VMs may get only one or two while my laptop reports eight. |
bestander
added a commit
to bestander/react-native
that referenced
this pull request
Feb 26, 2016
- removed env variables that I can't find if they are used anywhere - merged js tests into one command, see facebook#2981 for new discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packager and cli tests now run independently of the RN JS tests. When the packager moves to its own repo we can just remove the packager entry from .travis.yml.
The cli tests are also marked as allowed to fail for now.