Fix devDisabledInStaging not working with multiple productFlavors

[geraintwhite]

Fixes #27052

Summary

Since react-native 0.62, the devDisabledIn${buildType} syntax has stopped working for apps with multiple productFlavors. This PR adds the disableDevForVariant lambda to allow dev mode to be disabled for different variants.

Changelog

[Android] [Fixed] - Fix devDisabledIn not working with multiple productFlavors

Test Plan

I added the following log into react.gradle and ran the Android build for my app:

println("devEnabled: ${targetName}, ${devEnabled}")

# build.gradle

project.ext.react = [
    entryFile: "index.android.js",
    enableHermes: true,  // clean and rebuild if changing
    bundleInLive: true,
    disableDevForVariant: {
         def variant -> variant.name.toLowerCase().contains('release') || variant.name.toLowerCase().contains('live')
    },
]

...

flavorDimensions 'branding'
productFlavors {
    cve {
        dimension 'branding'
    }
    whce {
        dimension 'branding'
    }
}

Console output:

Reading env from: env/cve/live
devEnabled: CveDebug, true
devEnabled: CveRelease, false
devEnabled: CveLive, false
devEnabled: WhceDebug, true
devEnabled: WhceRelease, false
devEnabled: WhceLive, false

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: def7dd8
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,281,353	+0
android	hermes	armeabi-v7a	7,845,487	+0
android	hermes	x86	8,648,405	+0
android	hermes	x86_64	8,607,550	+0
android	jsc	arm64-v8a	9,798,170	+0
android	jsc	armeabi-v7a	8,759,118	+0
android	jsc	x86	9,747,085	+0
android	jsc	x86_64	10,347,948	+0

Base commit: def7dd8
Branch: main

[pull-bot]

PR build artifact for 75a2913 is ready.
To use, download tarball from this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[ShikaSD]

@grit96, thanks for submitting this!
similar to #32281 (comment), do you mind updating this flag to be a lambda to configure if dev is disabled based on variant + update the gradle plugin?

[geraintwhite]

@grit96, thanks for submitting this! similar to #32281 (comment), do you mind updating this flag to be a lambda to configure if dev is disabled based on variant + update the gradle plugin?

disableDevForVariant lambda added in both react.gradle and the gradle plugin.

[pull-bot]

PR build artifact for f38b56b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[geraintwhite]

@ShikaSD I noticed that the other config option that follows the devDisabledIn${targetName} pattern is bundleIn${targetName}. I'd be happy to do another PR converting that to a lambda too?

[ShikaSD]

I noticed that the other config option that follows the devDisabledIn${targetName} pattern is bundleIn${targetName}. I'd be happy to do another PR converting that to a lambda too?

Sure, feel free to! :)

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@ShikaSD merged this pull request in 055ea9c.