Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file and blob globals to eslint config #31293

Closed
wants to merge 2 commits into from

Conversation

shamilovtim
Copy link
Contributor

Summary

The eslint community config does not have the File and Blob polyfills in globals which have been part of the Javascript implementation for ~3 years. They were added to the Javascript API in #11573 by @satya164.

Changelog

[General] [Fixed] - Added File and Blob globals to eslint community config

Test Plan

Evidence these globals exist:

  1. Implement Blob support for XMLHttpRequest #11573
  2. Executed the following:

Screen Shot 2021-04-02 at 12 08 50 PM

Screen Shot 2021-04-02 at 12 11 56 PM

  1. Receive in console:

Screen Shot 2021-04-02 at 12 09 59 PM

Screen Shot 2021-04-02 at 12 12 27 PM

Evidence the PR works: the globals in the PR identical to the others in the eslint community config that they are in

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2021
@analysis-bot
Copy link

analysis-bot commented Apr 2, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dbe6fab
Branch: main

@sota000 sota000 added this to Needs Triage in React Native Pull Requests via automation Jul 27, 2021
@shamilovtim
Copy link
Contributor Author

ETA?

@cortinico
Copy link
Contributor

@shamilovtim don't you mind rebasing as you're far behind in the history. Afterwards we can merge this

@shamilovtim
Copy link
Contributor Author

@cortinico done

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,790,526 +0
android hermes armeabi-v7a 7,179,502 +0
android hermes x86 8,100,411 +0
android hermes x86_64 8,078,241 +0
android jsc arm64-v8a 9,655,802 +0
android jsc armeabi-v7a 8,413,668 +0
android jsc x86 9,606,448 +0
android jsc x86_64 10,201,297 +0

Base commit: dbe6fab
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

React Native Pull Requests automation moved this from Needs Triage to Closed Jun 17, 2022
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @shamilovtim in d881c87.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 17, 2022
@shamilovtim shamilovtim deleted the fix-add-eslint-globals branch June 17, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants